Closed
Conversation
fabpot
approved these changes
May 10, 2025
fabpot
force-pushed
the
check-dev-conflicts
branch
from
05bcffd to
5cc9859
Compare
fabpot
added a commit
that referenced
this pull request
May 10, 2025
This PR was merged into the 2.x branch. Discussion ---------- Always include locked dev packages It took me ages to find this hidden bug. When fetching the locked repository, Composer by default does not include dev packages. This means that conflicts for dev packages defined by Flex recipes were always completely ignored (like the `phpunit/phpunit: <9.6` conflict in our `symfony/phpunit-bridge` recipe). This creates big issues for my new PHPUnit recipe (symfony/recipes#1401), as the 10+ recipe is run for applications using PHPUnit 9. Commits ------- 05bcffd Always include locked dev packages
Member
|
Merged in 2.x |
Member
|
Thank you so much @wouterj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me ages to find this hidden bug.
When fetching the locked repository, Composer by default does not include dev packages. This means that conflicts for dev packages defined by Flex recipes were always completely ignored (like the
phpunit/phpunit: <9.6conflict in oursymfony/phpunit-bridgerecipe).This creates big issues for my new PHPUnit recipe (symfony/recipes#1401), as the 10+ recipe is run for applications using PHPUnit 9.