Skip to content

Add recipe for sylius/wishlist-plugin #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpysiak
Copy link

@mpysiak mpysiak commented May 20, 2025

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) May 20, 2025 06:24
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1800/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1800/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'sylius/wishlist-plugin:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@fabpot
Copy link
Member

fabpot commented May 20, 2025

https://packagist.org/packages/sylius/wishlist-plugin does not exist yet.

@@ -0,0 +1,2 @@
sylius_wishlist_shop:
resource: "@SyliusWishlistPlugin/config/routes.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
resource: "@SyliusWishlistPlugin/config/routes.yaml"
resource: "@SyliusWishlistPlugin/config/routes/shop.yaml"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants