-
-
Notifications
You must be signed in to change notification settings - Fork 496
[Symfony UX Map] Add post-install steps for Leaflet and Google, add "ux_map.google_maps.default_map_id" config recipe #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/ux-google-map2.19 vs 2.22diff --git a/symfony/ux-google-map/2.19/manifest.json b/symfony/ux-google-map/2.22/manifest.json
index 0adf0fc..eb14c9e 100644
--- a/symfony/ux-google-map/2.19/manifest.json
+++ b/symfony/ux-google-map/2.22/manifest.json
@@ -2,6 +2,15 @@
"conflict": {
"symfony/flex": "<1.20.0 || >=2.0.0,<2.3.0"
},
+ "add-lines": [
+ {
+ "file": "config/packages/ux_map.yaml",
+ "position": "after_target",
+ "warn_if_missing": true,
+ "target": " renderer: '%env(resolve:default::UX_MAP_DSN)%'",
+ "content": " google_maps:\n # define the default map id for all maps (https://developers.google.com/maps/documentation/get-map-id)\n default_map_id: null"
+ }
+ ],
"env": {
"#1": "Options available at https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Google/README.md",
"#2": "", |
Head branch was pushed to by a user without write access
84f9f34
to
23244b1
Compare
…ux_map.google_maps.default_map_id" config recipe
23244b1
to
cda40e9
Compare
Follow symfony/ux#2358, I've also added post-install steps.
Version 2.22 is not released yet, but 2.19 is
