Skip to content

Document #[WithHttpStatus] and #[WithLogLevel] on interfaces #19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

priyadi
Copy link
Contributor

@priyadi priyadi commented Dec 27, 2023

resolves #19337

OskarStark and others added 30 commits November 22, 2023 11:47
* 7.0:
  docs: fix typo
  Typo
…with ContainerConfigurator (alexandre-daubois)

This PR was merged into the 7.1 branch.

Discussion
----------

[DependencyInjection] Prepend extension config with ContainerConfigurator

Fix symfony#19153

Commits
-------

64ad9e6 [DependencyInjection] Prepend extension config with ContainerConfigurator
* upstream/7.0:
  -
  fix(doc): typo
  HttpKernelInterface::handle parameter and return types
  docs: fix typo
  remove versionadded directive for 6.3
  Typo
* 6.4:
  Remove "--unpack" option from setup.rst
  [HttpClient] Symfony HTTP Client documentation
  Update license.rst
  add links label in service container page
* 7.0:
  Remove "--unpack" option from setup.rst
  [HttpClient] Symfony HTTP Client documentation
  Update license.rst
  add links label in service container page
…erminating()` (alexandre-daubois)

This PR was merged into the 7.1 branch.

Discussion
----------

[HttpKernel] Introduce `ExceptionEvent::isKernelTerminating()`

Fix symfony#19174

Commits
-------

7cc8290 [HttpKernel] Introduce `ExceptionEvent::isKernelTerminating()`
* 6.4:
  -
  [AssetMapper] Exclude dot files
  Remove "--unpack" option from setup.rst
  Tweak
  Tweak
  [HttpClient] Symfony HTTP Client documentation
  Update license.rst
  add links label in service container page
* 7.0:
  -
  [AssetMapper] Exclude dot files
* 6.4:
  -
  fix: serializer includes only accessible attributes by default
* 7.0:
  -
  fix: serializer includes only accessible attributes by default
* 6.4:
  [Messenger] Update docs for Redis transport about TLS support
* 7.0:
  [Messenger] Update docs for Redis transport about TLS support
* 6.4:
  Adding precision on how to define attributes on the root node for the XML Encoder
* 7.0:
  Adding precision on how to define attributes on the root node for the XML Encoder
* 6.4:
  re-add versionadded directive
* 7.0:
  remove versionadded directives for Symfony 6
  re-add versionadded directive
* origin/6.4:
  AssetMapper 6.4 docs
* 6.4:
  Fix return type deprecations
  Fix deprecations return void
* 7.0:
  Fix return type deprecations
  Fix deprecations return void
  AssetMapper 6.4 docs
* 6.4:
  fix type of `$response->headers->set()`
* 7.0:
  fix type of `$response->headers->set()`
* 6.4:
  Fix typo in http_client.rst
* 7.0:
  Fix typo in http_client.rst
* upstream/7.0:
  Fix typo in http_client.rst
  fix type of `$response->headers->set()`
  Fix return type deprecations
  Fix deprecations return void
  AssetMapper 6.4 docs
  remove versionadded directives for Symfony 6
  re-add versionadded directive
  Adding precision on how to define attributes on the root node for the XML Encoder
  -
  [Messenger] Update docs for Redis transport about TLS support
  -
  fix: serializer includes only accessible attributes by default
  -
  [AssetMapper] Exclude dot files
…rrabus)

This PR was merged into the 7.0 branch.

Discussion
----------

Document requirements for DoctrineDbalAdapter

Follows symfony/symfony#52720. I've added a block that documents the compatibility with various database engines.

* MySQL 5.7 is the oldest release supported by DBAL 3.
* MariaDB 10.2 is the oldest release supported by DBAL 3.
* The `MERGE` statement that the adapter uses requires Oracle 10g or newer.
* SQL Server 2012 is the oldest release supported by DBAL 3.
* The `INSERT OR REPLACE` statement that we use on SQLite requires PHP to be linked against libsqlite 3.24 or newer.
* The `ON CONFLICT` clause that we use on Postgres was introduced with version 9.5.

Commits
-------

4127633 Document requirements for DoctrineDbalAdapter
javiereguiluz and others added 25 commits December 26, 2023 09:04
* 7.0:
  syntax tweaks
…oji('strip')` (smnandre)

This PR was squashed before being merged into the 7.0 branch.

Discussion
----------

[String] Remove confusing paragraph about `withEmoji('strip')`

The AsciiSlugger does remove every emoji from a given string per default without any external component or package, as they are not... ASCII.

The paragraph added some confusion to the reader, implying that
* AsciiSlugger did not work with emoji per default
* the special locale + the Intl component was required

So i suggest to purely remove it.

Commits
-------

9f4b626 [String] Remove confusing paragraph about `withEmoji('strip')`
This PR was squashed before being merged into the 7.0 branch.

Discussion
----------

Remove reference to some removed classes

Based on code [upgrade 7.0](https://github.com/symfony/symfony/blob/7.0/UPGRADE-7.0.md), remove from docs some removed classes in code

Commits
-------

8d69319 Remove reference to some removed classes
* 6.4:
  [Value Resolver] Added `RequestPayloadValueResolver` section
* 7.0:
  Remove reference to some removed classes
  [String] Remove confusing paragraph about `withEmoji('strip')`
  [Value Resolver] Added `RequestPayloadValueResolver` section
* 6.4:
  Mutate some `cautions` to `dangers`
* 7.0:
  Mutate some `cautions` to `dangers`
* 6.4:
  Mention Symfony CLI workers where applicable
* 7.0:
  Mention Symfony CLI workers where applicable
…d (Dean151)

This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[HttpClient] Add `HttpOptions::addHeader` method

Fixes symfony#19236

Not sure of the documentation format. Open to suggestion to improve it :)

Commits
-------

436f69e [HttpClient] Add `HttpOptions::addHeader` method
* 6.4:
  [Translation] Add a tip about Crowdin language mapping
* 7.0:
  [Translation] Add a tip about Crowdin language mapping
This PR was merged into the 7.1 branch.

Discussion
----------

[Notifier] Add Smsbox notifier bridge

Commits
-------

62aeccb [Notifier] Add Smsbox notifier bridge
In Symfony version 7, we don't have a loader for the annotations
This PR was submitted for the 7.1 branch but it was merged into the 7.0 branch instead.

Discussion
----------

[Documentation][Routing] Update routing.rst

In Symfony version 7, we don't have a loader for the annotations

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

35e2703 Update routing.rst
* 7.0:
  Update routing.rst
This PR was merged into the 7.1 branch.

Discussion
----------

Rename `addHeader` to `setHeader`

Follows
* symfony/symfony#53218

Commits
-------

bc95bcc Rename `addHeader` to `setHeader`
@priyadi priyadi requested a review from xabbuh as a code owner December 27, 2023 13:27
@carsonbot carsonbot added this to the 6.4 milestone Dec 27, 2023
@priyadi priyadi marked this pull request as draft December 27, 2023 13:28
@priyadi priyadi closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpKernel] Allow #[WithHttpStatus] and #[WithLogLevel] to take ef…