EarlyHints - mention RoadRunner support#22327
Open
FluffyDiscord wants to merge 1 commit into
Open
Conversation
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly, the RR package in this PR diff does not support Symfony Kernel by itself, it's not a runtime. However there is Symfony bundle adding runtime with early hints support built-in. Thus, I am not sure, if current link to RR itself can be referenced, or if the bundle supporting RR as runtime that supports these early hints should be referenced instead. If the bundle can actually be referenced in official symfony docs, but wording needs to be adjusted or there are steps to take to allow that, please point me to the right direction if possible.