Remove symfony/phpunit-bridge from test-pack #24
Conversation
alexander-schranz
changed the title
| @@ -4,15 +4,13 @@ | |||
| "license": "MIT", | |||
| "description": "A pack for functional and end-to-end testing within a Symfony app", | |||
| "require": { | |||
| "phpunit/phpunit": "^9.5", | |||
There was a problem hiding this comment.
was only restricted to this version because of the bridge: #19
There was a problem hiding this comment.
Is it worth setting ^11.1 here, given that is the first PHPUnit version that is fully compatible with the features provided by PHPUnitBridge's deprecation system? Or would that be redundant, as Composer will automatically pick the latest version anyways?
There was a problem hiding this comment.
it should then be >=11.1 IMHO
There was a problem hiding this comment.
Based on symfony/recipes#1401 (comment), we may need to set this to some >=12.x version then. That could probably mean we have to delay this to Symfony 7.4?
There was a problem hiding this comment.
How does the "pack" behave with >= does it still require it as ^11.1 else a conflict would be better.
There was a problem hiding this comment.
shouldn't we move this constraint to the conflict section?
conflict with phpunit < 11.1
|
Great! Finally! |
|
@ucscode this PR installs the version which is compatible with your used PHP version as we changed from |
There was a problem hiding this comment.
@alexander-schranz can you please squash after adding the conflict line?
alexander-schranz
force-pushed
the
patch-1
branch
from
7bea7a6 to
c25e0d7
Compare
Fix #21
Reference: https://github.com/symfony/demo/pull/1549/files
I think the recommended way today should be work without the phpunit bridge and directly with phpunit.