Skip to content

Commit 13b40f4

Browse files
committed
minor #2780 [CI] Replace ramsey/composer-install by composer install in app-tests workflow (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [CI] Replace ramsey/composer-install by `composer install` in app-tests workflow | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> In #2607, https://github.com/symfony/ux/actions/runs/15297531864/job/43030093028?pr=2607 is shown as failed because step `Run Encore (dev)`, but in reality it fails before but that's not shown: ![image](https://github.com/user-attachments/assets/70d2d886-63c0-4147-a4e7-91447a5870a9) With this change (which also remove a dependency), I hope the error to be well shown Commits ------- 5db7b99 [CI] Replace ramsey/composer-install by `composer install` in app-tests workflow
2 parents 59e840d + 5db7b99 commit 13b40f4

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/app-tests.yaml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,15 @@ jobs:
4545
- uses: shivammathur/setup-php@v2
4646

4747
- name: Install root dependencies
48-
uses: ramsey/composer-install@v3
49-
with:
50-
working-directory: ${{ github.workspace }}
48+
run: composer install
5149

5250
- name: Build root packages
5351
run: php .github/build-packages.php
54-
working-directory: ${{ github.workspace }}
5552

5653
# We always install PHP deps because we of the UX Translator, which requires `var/translations` to exists
57-
- uses: ramsey/composer-install@v3
58-
with:
59-
dependency-versions: 'highest'
60-
working-directory: test_apps/encore-app
54+
- name: Install App dependenies
55+
run: composer update
56+
working-directory: test_apps/encore-app
6157

6258
- if: matrix.ux-packages-source == 'php-vendor'
6359
name: Refresh dependencies from vendor/

0 commit comments

Comments
 (0)