Skip to content

Commit 9cde8b8

Browse files
committed
minor #2265 [Autocomplete] Add missing types (smnandre)
This PR was merged into the 2.x branch. Discussion ---------- [Autocomplete] Add missing types Commits ------- 532d062 [Autocomplete] Add missing types
2 parents 7a626ef + 532d062 commit 9cde8b8

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

src/Autocomplete/src/AutocompleteBundle.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
*/
2121
final class AutocompleteBundle extends Bundle
2222
{
23-
public function build(ContainerBuilder $container)
23+
public function build(ContainerBuilder $container): void
2424
{
2525
$container->addCompilerPass(new AutocompleteFormTypePass());
2626
}

src/Autocomplete/src/AutocompleterRegistry.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ public function getAutocompleter(string $alias): ?EntityAutocompleterInterface
2828
return $this->autocompletersLocator->has($alias) ? $this->autocompletersLocator->get($alias) : null;
2929
}
3030

31+
/**
32+
* @return list<string>
33+
*/
3134
public function getAutocompleterNames(): array
3235
{
3336
return array_keys($this->autocompletersLocator->getProvidedServices());

src/Autocomplete/src/DependencyInjection/AutocompleteExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
*/
4141
final class AutocompleteExtension extends Extension implements PrependExtensionInterface
4242
{
43-
public function prepend(ContainerBuilder $container)
43+
public function prepend(ContainerBuilder $container): void
4444
{
4545
$bundles = $container->getParameter('kernel.bundles');
4646

@@ -61,7 +61,7 @@ public function prepend(ContainerBuilder $container)
6161
}
6262
}
6363

64-
public function load(array $configs, ContainerBuilder $container)
64+
public function load(array $configs, ContainerBuilder $container): void
6565
{
6666
$this->registerBasicServices($container);
6767
if (ContainerBuilder::willBeAvailable('symfony/form', Form::class, ['symfony/framework-bundle'])) {

src/Autocomplete/src/DependencyInjection/AutocompleteFormTypePass.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ class AutocompleteFormTypePass implements CompilerPassInterface
2929
/** @var string Tag applied to EntityAutocompleterInterface classes */
3030
public const ENTITY_AUTOCOMPLETER_TAG = 'ux.entity_autocompleter';
3131

32-
public function process(ContainerBuilder $container)
32+
public function process(ContainerBuilder $container): void
3333
{
3434
$this->processEntityAutocompleteFieldTag($container);
3535
$this->processEntityAutocompleterTag($container);
3636
}
3737

38-
private function processEntityAutocompleteFieldTag(ContainerBuilder $container)
38+
private function processEntityAutocompleteFieldTag(ContainerBuilder $container): void
3939
{
4040
foreach ($container->findTaggedServiceIds(self::ENTITY_AUTOCOMPLETE_FIELD_TAG, true) as $serviceId => $tag) {
4141
$serviceDefinition = $container->getDefinition($serviceId);
@@ -68,7 +68,7 @@ private function getAlias(string $serviceId, Definition $serviceDefinition, arra
6868
return $attribute->getAlias() ?: AsEntityAutocompleteField::shortName($class);
6969
}
7070

71-
private function processEntityAutocompleterTag(ContainerBuilder $container)
71+
private function processEntityAutocompleterTag(ContainerBuilder $container): void
7272
{
7373
$servicesMap = [];
7474
foreach ($container->findTaggedServiceIds(self::ENTITY_AUTOCOMPLETER_TAG, true) as $serviceId => $tag) {

src/Autocomplete/src/Maker/MakeAutocompleteField.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public static function getCommandDescription(): string
5353
return 'Generates an Ajax-autocomplete form field class for symfony/ux-autocomplete.';
5454
}
5555

56-
public function configureCommand(Command $command, InputConfiguration $inputConfig)
56+
public function configureCommand(Command $command, InputConfiguration $inputConfig): void
5757
{
5858
$command
5959
->setHelp(<<<EOF
@@ -66,12 +66,12 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
6666
;
6767
}
6868

69-
public function configureDependencies(DependencyBuilder $dependencies)
69+
public function configureDependencies(DependencyBuilder $dependencies): void
7070
{
7171
$dependencies->addClassDependency(FormInterface::class, 'symfony/form');
7272
}
7373

74-
public function interact(InputInterface $input, ConsoleStyle $io, Command $command)
74+
public function interact(InputInterface $input, ConsoleStyle $io, Command $command): void
7575
{
7676
if (null === $this->doctrineHelper) {
7777
throw new \LogicException('Somehow the DoctrineHelper service is missing from MakerBundle.');
@@ -94,7 +94,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
9494
);
9595
}
9696

97-
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
97+
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
9898
{
9999
if (null === $this->doctrineHelper) {
100100
throw new \LogicException('Somehow the DoctrineHelper service is missing from MakerBundle.');

0 commit comments

Comments
 (0)