RequestPropsExtractorTest

Author: mbuliard

src/LiveComponent/src/Util/RequestPropsExtractor.php

@@ -35,7 +35,6 @@ public function extract(Request $request, LiveComponentMetadata $metadata, objec
     {
         $parameters = array_merge($request->attributes->all(), $request->query->all());
 
-        // @todo never empty because custom values prefixed with _ ... do something ?
         if (empty($parameters)) {
             return [];
         }

src/LiveComponent/tests/Functional/Util/RequestPropsExtractorTest.php

@@ -25,11 +25,12 @@ class RequestPropsExtractorTest extends KernelTestCase
     /**
      * @dataProvider getQueryStringTests
      */
-    public function testExtract(string $queryString, array $expected)
+    public function testExtractFromQueryString(string $queryString, array $expected, array $attributes = []): void
     {
         $extractor = new RequestPropsExtractor($this->hydrator());
 
         $request = Request::create('/'.!empty($queryString) ? '?'.$queryString : '');
+        $request->attributes->add($attributes);
 
         /** @var LiveComponentMetadataFactory $metadataFactory */
         $metadataFactory = self::getContainer()->get('ux.live_component.metadata_factory');
@@ -65,6 +66,10 @@ public function getQueryStringTests(): iterable
             'invalid array value' => ['arrayProp=foo', []],
             'invalid object value' => ['objectProp=foo', []],
             'aliased prop' => ['q=foo', ['boundPropWithAlias' => 'foo']],
+            'attribute prop' => ['', ['stringProp' => 'foo'], ['stringProp' => 'foo']],
+            'attribute aliased prop' => ['', ['boundPropWithAlias' => 'foo'], ['q' => 'foo']],
+            'attribute not bound prop' => ['', [], ['unboundProp' => 'foo']],
+            'query priority' => ['stringProp=foo', ['stringProp' => 'foo'], ['stringProp' => 'bar']],
         ];
     }
 }