You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This approach means that only icons directly referenced in templates are locked when running the icon:lock command.
Problem
Some icons are defined as aliases in the ux_icons configuration file. These aliased icons are not detected by IconFinder and therefore are not locked automatically, which can lead to inconsistencies during deployment.
Request
Would it be possible to add support for scanning icon aliases defined in the ux_icons file, in addition to using the regex to search templates? This enhancement would ensure that all icons actually used in the application are properly locked.
The text was updated successfully, but these errors were encountered:
jvancoillie
changed the title
[RFC][Icons] Add Support for Icon Aliases During icon:lock Command
[Icons] Add Support for Icon Aliases During icon:lock Command
Nov 9, 2024
jvancoillie
changed the title
[Icons] Add Support for Icon Aliases During icon:lock Command
[Icons] Add support for icon aliases during icon:lock command
Nov 9, 2024
smnandre
added a commit
to smnandre/ux
that referenced
this issue
Nov 9, 2024
Context
Currently, the
IconFinder
only scans templates to identify used icons, using the following regex:This approach means that only icons directly referenced in templates are locked when running the
icon:lock
command.Problem
Some icons are defined as aliases in the
ux_icons
configuration file. These aliased icons are not detected byIconFinder
and therefore are not locked automatically, which can lead to inconsistencies during deployment.Request
Would it be possible to add support for scanning icon aliases defined in the
ux_icons
file, in addition to using the regex to search templates? This enhancement would ensure that all icons actually used in the application are properly locked.The text was updated successfully, but these errors were encountered: