Skip to content

[TwigComponent] Store mount methods in compiler pass #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2024
Merged

[TwigComponent] Store mount methods in compiler pass #2357

merged 1 commit into from
Nov 10, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Nov 10, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

(internal optimization)

  • collection mount metadata (premount, mount, postmount) in compiler pass
  • store in ComponentMetadata object
  • start removing methods from AsTwigComponent

Note: i had to update an internal test method in LiveComponent

@smnandre smnandre force-pushed the twig/component-mount-compiled branch from 78a5a01 to 92e008e Compare November 10, 2024 04:40
@smnandre smnandre requested a review from kbond November 10, 2024 04:40
@smnandre smnandre force-pushed the twig/component-mount-compiled branch from ced6a67 to 2d93238 Compare November 10, 2024 04:58
@smnandre
Copy link
Member Author

Fabbot false positive, let's irgnore

Kocal
Kocal approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it should be more performant than before :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 10, 2024
@smnandre smnandre force-pushed the twig/component-mount-compiled branch from 2d93238 to c67028f Compare November 10, 2024 15:16
@smnandre smnandre merged commit 222973e into symfony:2.x Nov 10, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Performance Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @kbond @Kocal @carsonbot