Skip to content

add the new ProgressIndicator #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Nov 11, 2024

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 11, 2024
@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Nov 11, 2024
Co-authored-by: Hugo Alliaume <hugo@alliau.me>
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Nov 11, 2024
@smnandre
Copy link
Member

I imagine this might be fun, but this may not be the best place to do it since this command runs in ... less than 200ms. 😅

I tried it out but couldn't even catch the beginning of any animation here.

I'll close this for now, but thank you for the effort / creativity! Would welcome other similar PR with joy :)

progressindicator.mov

@smnandre smnandre closed this Nov 11, 2024
@tacman
Copy link
Contributor Author

tacman commented Nov 11, 2024

Understood. In the process, though, I found an error in the blog post: https://symfony.com/blog/new-in-symfony-7-2-console-finished-indicator#comment-25571 so it was a worthwhile exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants