[LiveComponent] Fix `PropertyTypeExtractorInterface::getTypes()` deprecation, use TypeInfo ^7.2 `Type` #2607

mtarld · 2025-02-26T16:58:40Z

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #1708
License	MIT

Fix the PropertyTypeExtractorInterface::getTypes() deprecation and use PropertyTypeExtractorInterface::getType() (based on TypeInfo Type) instead.

This PR allows TypeInfo ^7.2 to be used, thanks to the compatibility layers added for Type::accepts() and Type::traverse() (added in 7.3). In order to reduce frictions when users will upgrade their apps dependencies.

The CI changed a bit too:

When testing LiveComponent, with PHP 8.2, we install symfony/property-info:7.1.* symfony/type-info:7.2.*
When testing LiveComponent, with PHP 8.3, we install symfony/property-info:7.2.* symfony/type-info:7.2.*
When testing LiveComponent, with PHP 8.4, we install symfony/property-info:7.3.* symfony/type-info:7.3.*
When testing LiveComponent, with PHP 8.4 (and dev deps), we install symfony/property-info:>=7.3 symfony/type-info:>=7.3

Allowing us to covers a maximum versions of PropertyInfo and TypeInfo.

mtarld · 2025-02-26T17:28:20Z

Actually, didn't notice that PHP 8.1 is still supported by Symfony UX.
Unfortunately, it'll prevent symfony/type-info to be installed in that version.

src/LiveComponent/composer.json

mtarld · 2025-02-26T18:25:36Z

Anyway, I think we must wait for the bump of PHP in composer.json (ie: symfony/ux-live-component:^3.0).

Kocal · 2025-02-26T18:26:04Z

Added milestone 3.x

This PR was merged into the 7.3 branch. Discussion ---------- [PropertyInfo] Deprecate `Type` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | | License | MIT A new attempt to #53160, now that `symfony/type-info` is not experimental anymore. Deprecates: - `Type` class in favor of the `Type` class of `symfony/type-info` - `PropertyTypeExtractorInterface::getTypes()` in favor of the `PropertyTypeExtractorInterface::getType()` method - `ConstructorArgumentTypeExtractorInterface::getTypesFromConstructor()` in favor of the `ConstructorArgumentTypeExtractorInterface::getTypeFromConstructor()` method The work for upgrading dependent packages has begun already: - api-platform/core#6979 - symfony/ux#2607 Commits ------- 4d2ccf4 Fix md formatting f819aed [PropertyInfo] Deprecate Type

This PR was merged into the 7.3 branch. Discussion ---------- [PropertyInfo] Deprecate `Type` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | | License | MIT A new attempt to symfony/symfony#53160, now that `symfony/type-info` is not experimental anymore. Deprecates: - `Type` class in favor of the `Type` class of `symfony/type-info` - `PropertyTypeExtractorInterface::getTypes()` in favor of the `PropertyTypeExtractorInterface::getType()` method - `ConstructorArgumentTypeExtractorInterface::getTypesFromConstructor()` in favor of the `ConstructorArgumentTypeExtractorInterface::getTypeFromConstructor()` method The work for upgrading dependent packages has begun already: - api-platform/core#6979 - symfony/ux#2607 Commits ------- 4d2ccf4ac94 Fix md formatting f819aed8d13 [PropertyInfo] Deprecate Type

src/LiveComponent/src/DependencyInjection/LiveComponentExtension.php

Kocal · 2025-05-27T08:13:17Z

@mtarld Sorry to bring this up again, but are we sure it's not possible at all to ship this PR for 2.x?
Like, if we remove the symfony/type-info from require-dev, and tweak the CI to install it when PHP >=8.2?

mtarld · 2025-05-27T08:28:29Z

The UX LiveComponent is requiring a too low PHP version (lower than TypeInfo), which means that a composer install in low deps will fail. Therefore we can't have symfony/type-info in the composer.json file.

As discussed with @Kocal , the solution for 2.x will be:

Telling in the documentation to run composer require symfony/type-info in order to kill the deprecation (if they're using a lower version than 7.3, it won't be any deprecation).
Do the same in the CI.
Make sure that the code work for either PropertyInfo and TypeInfo.

Then for 3.x:

Remove the BC layer for PropertyInfo's Type
Bump the minimum PHP version
Require symfony/type-info in composer.json

I'll update the PR in that way ASAP 🙂

smnandre · 2025-05-28T00:53:11Z

Do the same in the CI.

I'd like to keep the CI testing the actual behaviour users would have with 8.1 🤷

@mtarld poke me if you want some hand there :)

Kocal · 2025-05-28T06:29:31Z

I'd like to keep the CI testing the actual behaviour users would have with 8.1 🤷

It won't change for 8.1, since symfony/type-info is not installable, but it will change for higher jobs

mtarld · 2025-05-28T09:55:17Z

Status: Needs Work

…atibility layer

…ly available in TypeInfo 7.3)

Kocal · 2025-05-29T10:08:29Z

I rebased the PR but didn't squash my commits (if it can ease reviews), CI is full green (we can ignore fabbot).

After reviews, we can merge this PR for UX 2.x instead of 3.x, since the initial PR changed from "only use TypeInfo" to "use TypeInfo when possible" 🎉

kbond

Wow, nice work @mtarld & @Kocal! I didn't think we'd see the CI green again in 2.x!

smnandre · 2025-05-30T01:02:39Z

Wow so nice!

carsonbot added LiveComponent Status: Needs Review Needs to be reviewed labels Feb 26, 2025

mtarld force-pushed the feat/type-info-type branch 3 times, most recently from 87a72aa to d3edb38 Compare February 26, 2025 17:16

mtarld force-pushed the feat/type-info-type branch 3 times, most recently from 8777e0e to 81650fd Compare February 26, 2025 17:36

mtarld commented Feb 26, 2025

View reviewed changes

src/LiveComponent/composer.json Outdated Show resolved Hide resolved

Kocal added this to the 3.x milestone Feb 26, 2025

mtarld mentioned this pull request Mar 3, 2025

[PropertyInfo] Deprecate Type symfony/symfony#59902

Merged

stof reviewed May 13, 2025

View reviewed changes

src/LiveComponent/src/DependencyInjection/LiveComponentExtension.php Outdated Show resolved Hide resolved

Kocal mentioned this pull request May 27, 2025

[LiveComponent] PropertyInfoExtractor::getTypes() method is deprecated #2778

Open

mtarld force-pushed the feat/type-info-type branch from 81650fd to 69cdc81 Compare May 28, 2025 09:49

carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels May 28, 2025

mtarld force-pushed the feat/type-info-type branch from 69cdc81 to 3ce901a Compare May 28, 2025 10:14

carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels May 28, 2025

Kocal mentioned this pull request May 28, 2025

[CI] Replace ramsey/composer-install by composer install in app-tests workflow #2780

Merged

Kocal force-pushed the feat/type-info-type branch from d9f68c9 to a615100 Compare May 29, 2025 08:18

Kocal requested review from kbond and smnandre May 29, 2025 08:23

Kocal force-pushed the feat/type-info-type branch 12 times, most recently from 2e5126f to 0b25cab Compare May 29, 2025 10:01

Kocal changed the title ~~[LiveComponent] Fix PropertyTypeExtractorInterface::getTypes() deprecation, use TypeInfo Type~~ [LiveComponent] Fix PropertyTypeExtractorInterface::getTypes() deprecation, use TypeInfo ^7.2 Type May 29, 2025

mtarld and others added 8 commits May 29, 2025 12:06

[LiveComponent] Use TypeInfo Type

e4008de

[LiveComponent] fix conflict on symfony/property-info

2fb7a8e

[LiveComponent] remove dd()

0c8aa18

[LiveComponent] add changelog entry

61043d7

[LiveComponent] tweak CI

19a1e88

[LiveComponent] Remove conflict with symfony/type-info:<7.3, add comp…

7c1c2d3

…atibility layer

[LiveComponent] correctly use $t from TypeHelper::traverse() iteration

5a24c82

[LiveComponent] Add compatibility layer for Type::accepts() too (on…

b12ee10

…ly available in TypeInfo 7.3)

Kocal force-pushed the feat/type-info-type branch from 0b25cab to b12ee10 Compare May 29, 2025 10:06

kbond approved these changes May 29, 2025

View reviewed changes

carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[LiveComponent] Fix `PropertyTypeExtractorInterface::getTypes()` deprecation, use TypeInfo ^7.2 `Type` #2607

[LiveComponent] Fix `PropertyTypeExtractorInterface::getTypes()` deprecation, use TypeInfo ^7.2 `Type` #2607

mtarld commented Feb 26, 2025 •

edited by Kocal

Loading

Uh oh!

mtarld commented Feb 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

mtarld commented Feb 26, 2025

Uh oh!

Kocal commented Feb 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Kocal commented May 27, 2025

Uh oh!

mtarld commented May 27, 2025

Uh oh!

smnandre commented May 28, 2025

Uh oh!

Kocal commented May 28, 2025

Uh oh!

mtarld commented May 28, 2025

Uh oh!

Kocal commented May 29, 2025 •

edited

Loading

Uh oh!

kbond left a comment

Uh oh!

smnandre commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

[LiveComponent] Fix PropertyTypeExtractorInterface::getTypes() deprecation, use TypeInfo ^7.2 Type #2607

Are you sure you want to change the base?

[LiveComponent] Fix PropertyTypeExtractorInterface::getTypes() deprecation, use TypeInfo ^7.2 Type #2607

Conversation

mtarld commented Feb 26, 2025 • edited by Kocal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtarld commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mtarld commented Feb 26, 2025

Uh oh!

Kocal commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Kocal commented May 27, 2025

Uh oh!

mtarld commented May 27, 2025

Uh oh!

smnandre commented May 28, 2025

Uh oh!

Kocal commented May 28, 2025

Uh oh!

mtarld commented May 28, 2025

Uh oh!

Kocal commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kbond left a comment

Choose a reason for hiding this comment

Uh oh!

smnandre commented May 30, 2025

Uh oh!

Uh oh!

[LiveComponent] Fix `PropertyTypeExtractorInterface::getTypes()` deprecation, use TypeInfo ^7.2 `Type` #2607

[LiveComponent] Fix `PropertyTypeExtractorInterface::getTypes()` deprecation, use TypeInfo ^7.2 `Type` #2607

mtarld commented Feb 26, 2025 •

edited by Kocal

Loading

mtarld commented Feb 26, 2025 •

edited

Loading

Kocal commented Feb 26, 2025 •

edited

Loading

Kocal commented May 29, 2025 •

edited

Loading