[Map] Add multipolygon support

[dannyvw]

Q	A
Bug fix?	no
New feature?	yes
Docs?	yes/no
Issues	Fix #...
License	MIT

Add support for MultiPolygon https://leafletjs.com/reference.html#polygon & https://developers.google.com/maps/documentation/javascript/shapes?hl=fr#polygon_hole

[carsonbot]

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

[Kocal]

Thanks for your contribution!

Is it possible to have some preview of what it renders? Because I don't see anything on Leaflet website :/
Also, does it work with Google Maps?

[dannyvw]

Thanks for your contribution!

Is it possible to have some preview of what it renders? Because I don't see anything on Leaflet website :/ Also, does it work with Google Maps?

@Kocal It is the example under “Additionally, you can pass a multi-dimensional array to represent a MultiPolygon shape.” with the outer ring and hole.

Google Maps https://developers.google.com/maps/documentation/javascript/shapes#polygon_hole

[Kocal]

I meant a visual preview, with a map screenshot :D But that's fine, the Google Maps demo and tweaking Leaflet page helped me to understand what's a multipolygon:

So, to move forward, there are still modifications to do:

1. Improve the CHANGELOG, by quickly explaining what's a MultiPolygon with a small code example
2. Change the documentation too, to show how to create a MultiPolygon
3. Types for methods Polygon::__construct(), Polygon::toArray() and Polygon::fromArray() must be updated
4. Types for PolygonDefinition TypeScript type must also been updated

Feel free to ask if you need help, thanks! :)

[github-actions]

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

File	Before (Size / Gzip)	After (Size / Gzip)
Map
abstract_map_controller.d.ts	4.95 kB / 1.15 kB	4.97 kB0% / 1.16 kB+1% 📈

[dannyvw]

@Kocal I pushed some changes. Is this fine or should I do something more?

[Kocal]

That's much better, thanks! :)

Except the documentation/changelog things, that's great, I will try to find some time tonight to test your PR and some minor changes

[dannyvw]

@Kocal Let me know if I need to change something :)

[Kocal]

As mentioned in #2762 (comment), can you please check the checkbox to allow maintainers to edit your PR's code? It would makes things much easier to work on.

Thanks 🙏🏻

[dannyvw]

@Kocal I don’t see that option. I think this is because the fork is in a organisation?

I have added you to the repo.

[Kocal]

Yeah you are supposed to see this:

Maybe that's the fault of the organization thing, yes... I don't really know 😅

Thanks for the invitation tho, that's better than nothing :)

[Kocal]

Thank you @dannyvw.