[Turbo] Fix Turbo CI (PHPStan & Functional tests) #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
Kocal
force-pushed
the
phpstan-bootstrap
branch
5 times, most recently
from
13b3c53 to
98210ef
Compare
Kocal
changed the title
Kocal
changed the title
Kocal
force-pushed
the
phpstan-bootstrap
branch
2 times, most recently
from
d1389ea to
b35b60a
Compare
Kocal
commented
May 23, 2025
Kocal
force-pushed
the
phpstan-bootstrap
branch
2 times, most recently
from
83d2504 to
4540f38
Compare
Kocal
commented
May 23, 2025
Kocal
commented
May 23, 2025
Comment on lines
71
to
74
| if (!\is_string($topic)) { | ||
| $topics[] = $topic; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I and PHPStan does not see how $topic can not be a string at this point.
There was a problem hiding this comment.
friendly ping @rskuipers, by any chance :)
There was a problem hiding this comment.
Just in case of, I will revert this modification and ignore it from PHPStan, we will remove it safely in 3.x
Kocal
force-pushed
the
phpstan-bootstrap
branch
2 times, most recently
from
fd9ac0d to
8936341
Compare
Kocal
force-pushed
the
phpstan-bootstrap
branch
3 times, most recently
from
6834cfc to
9cbfdf8
Compare
|
Turbo tests still erroring? |
I did the fix in the wrong file 🤦🏻 |
|
However, sometimes we still have this flakky test: It looks like it only happens on lowest deps, I will try to increase the version constraints of panther / webdriver |
Kocal
force-pushed
the
phpstan-bootstrap
branch
4 times, most recently
from
93a6e7f to
b998040
Compare
…(Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Turbo] Fix Turbo CI (PHPStan & Functional tests) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Looks like the CI for Turbo was broken for a moment... let's fix it :) Commits ------- 37341b5 [Turbo] Fix Turbo CI (PHPStan & Functional tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the CI for Turbo was broken for a moment... let's fix it :)