Skip to content

[Map] Add missing dependency for spatie/phpunit-snapshot-assertions to require-dev #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented May 25, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

There is a reference to the spatie package inside https://github.com/symfony/ux/blob/2.x/src/Map/src/Test/RendererTestCase.php#L16

@dannyvw dannyvw requested a review from Kocal as a code owner May 25, 2025 12:30
@carsonbot carsonbot added Bug Bug Fix Map Status: Needs Review Needs to be reviewed labels May 25, 2025
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@Kocal
Copy link
Member

Kocal commented May 26, 2025

IIRC I did it on purpose, because it broke the Map CI, even if not used (the snapshot things is only used by Map Bridges tests).

As you can see, the job https://github.com/symfony/ux/actions/runs/15237882111/job/42854187001?pr=2773 is now failing:

Call to undefined method PHPUnit\TextUI\TestRunner::run()

Can you try adding "phpunit/phpunit": "^9.6.22" to Map's composer.json ?

@Kocal
Copy link
Member

Kocal commented May 26, 2025

Cool, it's working

@Kocal Kocal changed the title [Map] Add missing dependency for spatie/phpunit-snapshot-assertions t… [Map] Add missing dependency for spatie/phpunit-snapshot-assertions to require-dev May 26, 2025
@Kocal Kocal removed the Bug Bug Fix label May 26, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 26, 2025
@Kocal
Copy link
Member

Kocal commented May 26, 2025

Thank you @dannyvw.

@Kocal Kocal merged commit 59e840d into symfony:2.x May 26, 2025
25 of 37 checks passed
@Kocal Kocal deleted the spatie-req branch May 26, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants