[Shadcn] Add missing as props, update CONTRIBUTING.md #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ker0x
commented
Nov 12, 2025
ker0x
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Documentation? | no |
| Issues | - |
| License | MIT |
carsonbot
changed the title
ker0x
changed the title
ker0x
force-pushed
the
fix/shadcn-button-link-example
branch
2 times, most recently
from
e42d191 to
be4b9a8
Compare
Kocal
approved these changes
Nov 13, 2025
carsonbot
added
Status: Reviewed
carsonbot
changed the title
Kocal
force-pushed
the
fix/shadcn-button-link-example
branch
from
be4b9a8 to
e971f96
Compare
Kocal
reviewed
Nov 13, 2025
CONTRIBUTING.md
Outdated
Comment on lines
80
to
91
| #### Generate snapshots for UX Toolkit | ||
|
|
||
| If you make changes to a component template or add a new one, create or update the EXAMPLES.md of the component. | ||
| Then, you can (re)generate new snapshots by running: | ||
|
|
||
| ```shell | ||
| php vendor/bin/simple-phpunit -d --update-snapshots | ||
| ``` | ||
|
|
||
| > [!IMPORTANT] | ||
| > Snapshots will not reflect changes if you forget to update the EXAMPLES.md. | ||
Member
There was a problem hiding this comment.
This section is already present in the Toolkit/CONTRIBUTING.md file
[Toolkit][Shadcn] Add missing as props, update CONTRIBUTING.md
Kocal
force-pushed
the
fix/shadcn-button-link-example
branch
from
e971f96 to
56a8a90
Compare
Member
|
Thank you @ker0x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.