Skip to content

Unused files in distribution not ignored for export in gitignore #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
savinmikhail opened this issue Apr 26, 2025 · 1 comment
Open

Unused files in distribution not ignored for export in gitignore #244

savinmikhail opened this issue Apr 26, 2025 · 1 comment

Comments

@savinmikhail
Copy link
Contributor

Hi!

As I can see, when the lib being downloaded by composer, we get severalfiles in archive, that are not meant for te end-user, and just increasing the size of the dist. They are:

  • .editorconfig
  • psalm-baseline.xml
  • CONTRIBUTING.md

And possibly CHANGELOG.md too, but not sure

Thats about 7.2 kB of size.

If you agree, I be glad to submit a PR
@Kocal
Copy link
Member

Kocal commented Apr 26, 2025

Hi,

Thanks for noticing this, we would like to see a PR to fix it (the CHANGELOG.md file must not be ignored)

@savinmikhail savinmikhail mentioned this issue Apr 28, 2025
Merged
Kocal added a commit that referenced this issue May 2, 2025
@Kocal
minor #245 Unused files in distribution not ignored for export in git…
4bdad27 
…ignore (savinmikhail)

This PR was merged into the 2.x branch.

Discussion
----------

Unused files in distribution not ignored for export in gitignore

Linked issue is #244 (comment)

Commits
-------

abd2f37 fix(git): fix export-ignore directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kocal @savinmikhail