From bacdaeda21faa3640f2bbb217ba664cae2c43f33 Mon Sep 17 00:00:00 2001 From: sureshsf3950 <119393805+sureshsf3950@users.noreply.github.com> Date: Thu, 25 Jul 2024 14:08:00 +0530 Subject: [PATCH 1/3] 897996: After selecting the values, the selected values are in disabled state. ### Bug description Clearly and concisely describe the problem (this cannot be empty). ### Root cause Briefly describe the root cause and analysis of the problem. If there is an internal discussion on the forum, provide the link. ### Solution description Describe the changes made in the code in detail for the reviewers. ### Reason for not identifying earlier * [ ] Guidelines not followed. If yes, provide which guideline is not followed. * [ ] Guidelines not given. If yes, provide which/who need to address. Tag label `update-guideline-coreteam` or `update-guideline-productteam`. * [ ] If any other reason, provide the details here. ### Areas tested against this fix Provide details about the areas or combinations that have been tested against this code changes. * [ ] Tested against feature matrix. [Feature matrix link](https://syncfusion.sharepoint.com/sites/EJ2ProductOwners/Shared%20Documents/Forms/AllItems.aspx?viewid=ae81c682%2D3d0f%2D462a%2Db8ec%2D7358748d489d&id=%2Fsites%2FEJ2ProductOwners%2FShared%20Documents%2FGeneral%2FFeature%20Matrix%20%2D%20Documents) * [ ] NA ### Is it a breaking issue? * [ ] Yes, Tag `breaking-issue`. * [ ] NO If yes, provide the breaking commit details / MR here. ### Action taken What action did you take to avoid this in future? Feature matrix document updated * [ ] Yes * [ ] NO * [ ] NA Automation details - Mark `Is Automated` field as (Yes, Manual, Not Applicable) in corresponding JIRA task once the bug is automated. * [ ] BUnit, share corresponding MR. * [ ] E2E or Manual Automation using tester - Make sure all items are automated with priority before release which can be tracked in [automation dashboard](https://syncfusion.atlassian.net/secure/Dashboard.jspa?selectPageId=43396). If the same issue is reproduced in ej2, what will you do? * [ ] Resolved. Provide MR link. * [ ] NO. Created task to track it. Share task link. * [ ] NA Is this common issue need to be addressed in the same component or on other components in our platform? * [ ] Yes - Need to check in other components, tag `needs-attention-coreteam` * [ ] No ### Output screenshots Post the output screenshots if an UI is affected or added due to this bug. ### Blazor Checklist Confirm whether this feature is ensured in both Blazor Server and WASM * [ ] NA * [ ] Yes * [ ] NO Is there any new API or existing API name change? * [ ] Yes. If yes, Provide API Review task link. * [ ] NO Is there any existing behavior change due to this code change? * [ ] Yes. Add `breaking-change` label. * [ ] NO Do the code changes cause any memory leak and performance issue? (Test only if you suspect that your code may cause problem) * [ ] Yes * [ ] NO ### Reviewer Checklist * [ ] All provided information are reviewed and ensured. --- ej2-angular/dialog/getting-started.md | 51 ++++++--------------------- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git a/ej2-angular/dialog/getting-started.md b/ej2-angular/dialog/getting-started.md index c296df3b28..4d5133589c 100644 --- a/ej2-angular/dialog/getting-started.md +++ b/ej2-angular/dialog/getting-started.md @@ -101,51 +101,20 @@ To mention the ngcc package in the `package.json` file, add the suffix `-ngcc` w >Note: If the ngcc tag is not specified while installing the package, the Ivy Library Package will be installed and this package will throw a warning. -## Adding Dialog module - -Once you have successfully installed the popups package, the component modules are ready to configure in your application from the installed location. Syncfusion Angular package provides two different types of ngModules. - -Refer to [Ng-Module](https://ej2.syncfusion.com/angular/documentation/common/ng-module/) to learn about `ngModules`. - -Refer to the following snippet to import the `DialogModule` in `app.module.ts` from the `@syncfusion/ej2-angular-popups`. - -```javascript -import { BrowserModule } from '@angular/platform-browser'; -import { NgModule } from '@angular/core'; - -import { AppRoutingModule } from './app-routing.module'; -import { AppComponent } from './app.component'; -// Imported syncfusion DialogModule from popups package -import { DialogModule } from '@syncfusion/ej2-angular-popups'; - -@NgModule({ - declarations: [ - AppComponent - ], - imports: [ - BrowserModule, - AppRoutingModule, - // Registering EJ2 Dialog Module - DialogModule - ], - providers: [], - bootstrap: [AppComponent] -}) -export class AppModule { } - -``` - ## Adding Dialog component Add the Dialog component snippet in `app.component.ts` as follows. ```javascript -import { Component, ViewChild, OnInit, ElementRef } from '@angular/core'; -import { DialogComponent } from '@syncfusion/ej2-angular-popups'; -import { EmitType } from '@syncfusion/ej2-base'; +import { DialogModule } from '@syncfusion/ej2-angular-popups' +import { Component, ViewChild } from '@angular/core'; @Component({ +imports: [ + DialogModule + ], + standalone: true, selector: 'app-root', template: `
@@ -156,11 +125,11 @@ import { EmitType } from '@syncfusion/ej2-base';
` }) -export class AppComponent implements OnInit { +export class AppComponent { // Create element reference for dialog target element. - @ViewChild('ejDialog') ejDialog: DialogComponent; - - public onOpenDialog = function(event: any): void { + @ViewChild('ejDialog') ejDialog: any; + + public onOpenDialog = (event: any): void => { // Call the show method to open the Dialog this.ejDialog.show(); }; From 24bc0ed54a89ef25c4c6d11111143d1f83939218 Mon Sep 17 00:00:00 2001 From: sureshsf3950 <119393805+sureshsf3950@users.noreply.github.com> Date: Thu, 25 Jul 2024 14:11:25 +0530 Subject: [PATCH 2/3] 897996: After selecting the values, the selected values are in disabled state. --- .../multicolumn-combobox/getting-started.md | 46 ++++++++----------- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/ej2-angular/multicolumn-combobox/getting-started.md b/ej2-angular/multicolumn-combobox/getting-started.md index d071461a95..111291c871 100644 --- a/ej2-angular/multicolumn-combobox/getting-started.md +++ b/ej2-angular/multicolumn-combobox/getting-started.md @@ -94,26 +94,6 @@ To mention the ngcc package in the `package.json` file, add the suffix `-ngcc` w >Note: If the ngcc tag is not specified while installing the package, the Ivy Library Package will be installed and this package will throw a warning. -## Registering MultiColumn ComboBox module - -Import MultiColumn ComboBox module into Angular application(app.module.ts) from the package `@syncfusion/ej2-angular-multicolumn-combobox`. - -```javascript -import { NgModule } from '@angular/core'; -import { BrowserModule } from '@angular/platform-browser'; -// import the MultiColumn ComboBoxModule for the MultiColumn ComboBox component -import { MultiColumnComboBoxModule } from '@syncfusion/ej2-angular-multicolumn-combobox'; -import { AppComponent } from './app.component'; - -@NgModule({ - //declaration of ej2-angular-multicolumn-combobox module into NgModule - imports: [ BrowserModule, MultiColumnComboBoxModule ], - declarations: [ AppComponent ], - bootstrap: [ AppComponent ] -}) -export class AppModule { } -``` - ## Adding CSS reference The following CSS files are available in `../node_modules/@syncfusion` package folder. @@ -131,15 +111,21 @@ This can be referenced in [src/styles.css] using following code. Modify the template in [src/app/app.component.ts] file to render the Angular ComboBox component. Add the Angular MultiColumn ComboBox by using `` selector in `template` section of the app.component.ts file. ```javascript + +import { FormsModule, ReactiveFormsModule } from '@angular/forms' +import { MultiColumnComboBoxModule } from '@syncfusion/ej2-angular-multicolumn-combobox' +import { ButtonModule } from '@syncfusion/ej2-angular-buttons' import { Component } from '@angular/core'; -import { MultiColumnComboBoxComponent } from '@syncfusion/ej2-angular-multicolumn-combobox'; @Component({ - selector: 'app-root', - // specifies the template string for the MultiColumn ComboBox component - template: `` + imports: [ FormsModule, ReactiveFormsModule, MultiColumnComboBoxModule, ButtonModule ], + standalone: true, + selector: 'app-root', + // specifies the template string for the MultiColumn ComboBox component + template: `` }) export class AppComponent { } + ``` ## Binding data source with fields and columns @@ -147,10 +133,15 @@ export class AppComponent { } After initializing, populate the MultiColumn ComboBox with data by using the [dataSource](https://ej2.syncfusion.com/angular/documentation/api/multicolumn-combobox#datasource) property, to map the data for each specified columns use the `` selector and the [fields](https://ej2.syncfusion.com/angular/documentation/api/multicolumn-combobox#fields) property to map the data fields from the dataSource. ```typescript -import { Component } from '@angular/core'; -import { MultiColumnComboBoxComponent } from '@syncfusion/ej2-angular-multicolumn-combobox'; + +import { FormsModule, ReactiveFormsModule } from '@angular/forms' +import { MultiColumnComboBoxModule } from '@syncfusion/ej2-angular-multicolumn-combobox' +import { ButtonModule } from '@syncfusion/ej2-angular-buttons' +import { Component, HostListener, ViewChild } from '@angular/core'; @Component({ + imports: [ FormsModule, ReactiveFormsModule, MultiColumnComboBoxModule, ButtonModule ], + standalone: true, selector: 'app-root', // specifies the template string for the MultiColumn ComboBox component template: ` @@ -180,6 +171,7 @@ export class AppComponent { // maps the appropriate column to fields property public fields: Object = { text: 'Name', value: 'EmpID' }; } + ``` ## Running the application @@ -222,4 +214,4 @@ In the following sample, popup list's width and height are configured. {% endhighlight %} {% endtabs %} -{% previewsample "page.domainurl/samples/multicolumn-combobox/getting-started-cs2" %} \ No newline at end of file +{% previewsample "page.domainurl/samples/multicolumn-combobox/getting-started-cs2" %} From 77ed1ae36d5b60f9018f240421002a4d34ccb608 Mon Sep 17 00:00:00 2001 From: sureshsf3950 <119393805+sureshsf3950@users.noreply.github.com> Date: Thu, 25 Jul 2024 14:13:32 +0530 Subject: [PATCH 3/3] 897996: After selecting the values, the selected values are in disabled state. --- ej2-angular/multi-select/virtual-scroll.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ej2-angular/multi-select/virtual-scroll.md b/ej2-angular/multi-select/virtual-scroll.md index 51a355ac04..517415226e 100644 --- a/ej2-angular/multi-select/virtual-scroll.md +++ b/ej2-angular/multi-select/virtual-scroll.md @@ -41,7 +41,7 @@ In the following example, `id` column and `text` column from complex data have b ## Binding remote data -The MultiSelect supports the retrieval of data from remote data services with the help of the `DataManager` component, triggering the `actionBegin` and `actionComplete` events, and then updating the list data. During virtual scrolling, additional data is retrieved from the server, triggering the `actionBegin` and `actionComplete` events at that time as well. +The MultiSelect supports the retrieval of data from remote data services with the help of the `DataManager` component, triggering the `actionBegin` and `actionComplete` events, and then updating the list data. During virtual scrolling, additional data is retrieved from the server, triggering the `actionBegin` and `actionComplete` events at that time as well. The following sample displays the OrderId from the `Orders` Data Service. @@ -184,4 +184,4 @@ The following sample shows the example for Preselect value with Virtualization. {% endhighlight %} {% endtabs %} -{% previewsample "page.domainurl/samples/multiselect/virtual-scroll-preselect" %} \ No newline at end of file +{% previewsample "page.domainurl/samples/multiselect/virtual-scroll-preselect" %}