Skip to content

Voice Control name of SyncThing Icon is "Idle" #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justinrporter opened this issue Jan 6, 2022 · 6 comments
Closed

Voice Control name of SyncThing Icon is "Idle" #171

justinrporter opened this issue Jan 6, 2022 · 6 comments

Comments

@justinrporter
Copy link

Using MacOS's VoiceControl feature, the name of the dock icon for SyncThing is "Idle" (or presumably any of the other values this can take depending on sync status), likely because that's what the tooltip reads:

Screen Shot 2022-01-06 at 10 57 25 AM

The result is that to select the Syncthing tray icon, the user must speak "select idle".

I think it should be an easy fix: rename the tooltip to "Syncthing (Idle)" or something.

For example, "Click Dropbox" works when Dropbox's tooltip is longer.

Screen Shot 2022-01-06 at 10 58 07 AM

Thanks for the project, keep up the great work!

@xor-gate
Copy link
Member

xor-gate commented Jan 6, 2022

Hi @justinrporter,

At first, thanks for the generous one-time donation. It is indeed easy to fix and the dropbox tooltip is much more descriptive and complete. I will patch this before sunday evening and you can test if you want. I will let you know in this ticket.

Kind regards
Jerry

@xor-gate xor-gate added this to the v1.18.5-2 milestone Jan 8, 2022
@xor-gate
Copy link
Member

xor-gate commented Jan 8, 2022

Hi @justinrporter, I have improved the tooltip which looks now similar as dropbox. You may test the unreleased but signed dist version 2 by manual installing from here https://build.syncthing.net/viewLog.html?buildId=114784&buildTypeId=SyncthingMacOS_BuildReleaseDmg&tab=artifacts. Please let me know if this is what you expect.

@xor-gate
Copy link
Member

xor-gate commented Jan 8, 2022

Forgotten to say how it looks now:
Screenshot 2022-01-08 at 15 18 30

@justinrporter
Copy link
Author

It looks great!

Thanks so much... I hope you feel like it's an overall improvement, not just for accessibility reasons. I use your app on all my macs, thanks for keeping things up to date and running smoothly!

Cheers!

@xor-gate
Copy link
Member

xor-gate commented Jan 8, 2022

I find it a good improvement also, I have no Dropbox or other cloud sync tools so I could not compare the tooltip. Actually this request did some un-dusting of the status handling code so with a new release the pause will also be correctly displayed. See also #172.

@xor-gate
Copy link
Member

This issue is can be closed since commit has landed 5faae15. Feel free to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants