Clarify __init wording for loadable modules#361
Merged
jserv merged 1 commit intosysprog21:masterfrom Mar 1, 2026
Merged
Conversation
Replace the phrase "but not loadable modules" with more explicit description in section 4.3. The current wording can be misread as implying that __init has no observable effect for loadable modules.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
|
Thank @bclegend for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the phrase "but not loadable modules" with more explicit description in section 4.3.
The current wording can be misread as implying that __init has no observable effect for loadable modules.
closes #360
Summary by cubic
Clarifies the documentation for the __init macro to avoid implying it has no effect for loadable modules. The text now explains that __init still places functions in an init-only section for modules and that do_free_init may be observable during module loading.
Written for commit e25ae0b. Summary will update on new commits.