Improve CI/CD

[jserv]

Summary by cubic

Overhauled CI/CD to be faster, more reliable, and secure. Adds a reusable setup action, caching across dependencies and builds, strict Bash scripts, and workflow concurrency with timeouts.

• New Features

  • Added composite action to install rv32emu deps (Linux/macOS) with caching and PATH setup.
  • Enabled caching for APT, RISC-V toolchain, and build artifacts.
  • Set minimal workflow permissions and added concurrency to cancel redundant runs.
  • Applied step/job timeouts and recursive submodule checkout.

• Refactors

  • Introduced Bash strict mode, color logging, ASSERT, and a cleanup registry in CI scripts.
  • Simplified format checking using clang-format -n --Werror, black --check, and shfmt on tracked files.
  • Fixed shell scripts to use POSIX-friendly syntax and safer checks (case, command -v).
  • Minor reliability fixes in boot tests, gdb detection, and toolchain installer.

[cubic-dev-ai]

3 issues found across 7 files

Prompt for AI agents (all 3 issues)

Understand the root cause of the following 3 issues and fix them.


<file name=".github/actions/setup-rv32emu/action.yml">

<violation number="1" location=".github/actions/setup-rv32emu/action.yml:12">
apt-get install needs a non-interactive flag; without -y this step will block waiting for confirmation on GitHub runners, breaking the workflow.</violation>

<violation number="2" location=".github/actions/setup-rv32emu/action.yml:22">
The APT cache restore runs after apt-get install, so the restored packages never benefit the install step; move this caching step before the install to make it effective.</violation>
</file>

<file name=".ci/check-format.sh">

<violation number="1" location=".ci/check-format.sh:25">
`shfmt -d` exits 0 even when it would reformat files, so storing `$?` here keeps SH_FORMAT_EXIT at 0 and the CI will never fail on misformatted shell scripts. Please derive a non-zero value from `shfmt -l` or similar so the exit code reflects formatting problems.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

2 issues found across 6 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name=".ci/common.sh">

<violation number="1" location=".ci/common.sh:2">
Setting strict mode here will leak `-euo pipefail` into any shell that sources this helper (for example the workflow steps that do `. .ci/common.sh`), so later commands may now exit unexpectedly on previously tolerated non-zero statuses. Please avoid toggling shell options in a sourced library and move this to the scripts that execute directly, or guard it so it only runs when the file is executed.</violation>
</file>

<file name=".ci/check-format.sh">

<violation number="1" location=".ci/check-format.sh:10">
`mapfile` is only available in Bash 4+, but macOS (and any host that still uses Bash 3.2) will invoke this script with a shell that lacks that builtin. On those machines the format check now fails immediately with “mapfile: command not found”. Please avoid `mapfile` or ensure the script runs under a modern Bash.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}