Skip to content

Clarify hibernation disclaimer sentence #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

Clarify hibernation disclaimer sentence #1273

merged 3 commits into from
Mar 4, 2025

Conversation

leviport
Copy link
Member

@leviport leviport commented Feb 19, 2025 •
edited by ahoneybun
Loading

Closes #1269

depends on: #1278

@leviport leviport requested review from a team February 19, 2025 17:44
jacobgkau
jacobgkau approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@jacobgkau jacobgkau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the last clause of the sentence needed to go to address that issue, but I also think the disclaimer still works fine without it.

@leviport
Copy link
Member Author

leviport commented Mar 4, 2025

Idk how to fix that CI failure.

@ahoneybun
Copy link
Contributor

@leviport this should fix that issue:

#1278

@ahoneybun ahoneybun merged commit 012b4cb into master Mar 4, 2025
3 checks passed
@ahoneybun ahoneybun deleted the hibernation branch March 4, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobgkau jacobgkau jacobgkau approved these changes

+1 more reviewer

@ahoneybun ahoneybun ahoneybun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hibernation is or isn't supported?

3 participants

@leviport @ahoneybun @jacobgkau