Skip to content

Conversation

zazesty
Copy link

@zazesty zazesty commented Oct 13, 2025

Persistent battery charging thresholds were added to 2025-07-24 Open Firmware by writing to EC flash.
I edited this article to reflect this, reworking a paragraph to inform folks with new firmware that they may change charge thresholds in a persistent manner via the terminal (obviating systemd), and guiding folks using older firmware to the systemd procedure.
my first pull request, please let me know if i should do something differently.
Thank y'all!

Persistent battery charging thresholds were added to 2025-07-24 Open Firmware by writing to EC flash. 
I edited this article to reflect this, reworking a paragraph to inform folks with new firmware that they may change charge thresholds in a persistent manner via the terminal (obviating systemd), and guiding folks using older firmware to the systemd procedure. 
Thank y'all!
@leviport leviport requested review from a team October 13, 2025 17:01
@garrettjwilke
Copy link
Contributor

I think some changes are not necessary:
changing This feature is not currently finished. to This feature is not fully finished. does not make things clear. It is either finished or it is not, adding fully finished does not make sense.

We are updating firmware often, so I feel it might be better to not explicitly name the firmware version 2025-07-24_c242738 would become outdated.

@zazesty
Copy link
Author

zazesty commented Oct 13, 2025 via email

@jacobgkau
Copy link
Member

I went ahead and simplified this. The note isn't really needed at the top anymore now that the feature's fully implemented in firmware. We can just mention where the workaround's needed in its own section. The GUI can be added to the article once it's implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants