Skip to content

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Jul 16, 2024

Enable WDT to ensure the system:

  • Does not hang processing any task, such as previous cases of PECI commands never completing.
  • Does not take longer than the timeout period to complete all outstanding tasks.

A timeout of 8s is used to remain close to the existing use of the WDT in scratch ROM, which was set to 10s.

Ref: #389

Testing

  • That it works as intended:
    1. Flash custom build with debug logging enabled and wdt_kick removed from main loop
    2. Plug in the unit
    3. Observe EC init message ("System76 EC board...") occurs after ~8 seconds
    4. A second behaves like normal
  • Standard firmware validation tasks do not result in unexpected power off

@crawfxrd crawfxrd force-pushed the wdt branch 3 times, most recently from 57c91dc to 0d3361c Compare July 17, 2024 22:44
@crawfxrd crawfxrd force-pushed the wdt branch 6 times, most recently from 73303ba to d928881 Compare July 30, 2024 19:29
@crawfxrd crawfxrd requested review from a team December 5, 2024 06:24
@crawfxrd crawfxrd marked this pull request as ready for review December 5, 2024 06:27
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Enable WDT to ensure the system:

- Does not hang processing any task, such as previous cases of PECI
  commands never completing.
- Does not take longer than the timeout period to complete all
  outstanding tasks.

A timeout of 8s is used to remain close to the existing use of the WDT
in scratch ROM, which was set to 10s.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
Prevent a case where the board is unbootable due to WDT continuously
timing out. May allow recovery from OS depending on the cause.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants