Replace objcopy with makebin #521
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d36fb62 ("Replace makebin with objcopy"). Using objcopy from GCC 14.2 with the IHX produced by SDCC 4.5.0 results in an incorrectly sized ROM. Revert to using the tool provided by the SDCC toolchain. Produces different `flash.rom` and `scratch.rom`, but `ec.rom` is identical. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d36fb62 ("Replace makebin with objcopy").
Using objcopy from GCC 14.2 with the IHX produced by SDCC 4.5.0 results in an incorrectly sized ROM. Revert to using the tool provided by the SDCC toolchain.
Produces different
flash.romandscratch.rom, butec.romis identical.Ref: #518