Skip to content

gaze20 #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

gaze20 #626

merged 2 commits into from
Jul 2, 2025

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jun 24, 2025 •
edited
Loading

@jackpot51 jackpot51 mentioned this pull request Jun 26, 2025
Merged
@jackpot51 jackpot51 self-assigned this Jun 26, 2025
@jackpot51 jackpot51 requested review from a team June 26, 2025 19:29
@jackpot51 jackpot51 mentioned this pull request Jun 26, 2025
Merged
@jackpot51 jackpot51 marked this pull request as ready for review July 2, 2025 17:11
@crawfxrd
Copy link
Member

crawfxrd commented Jul 2, 2025

Need to check GPU Boost works after my changes. I matched proprietary behavior for "Set Controller Status", but this might just be disabling GPU Boost since I don't know if it's resetting the values afterwards (calling "Get Controller Params").

https://github.com/system76/coreboot/blob/1382fe920121412706addeb1a4b73a3b342c2fa0/src/drivers/gfx/nvidia/acpi/common/nvpcf.asl#L151-L158

crawfxrd
crawfxrd reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@crawfxrd crawfxrd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add model to Jenkinsfile
  • Update changelog
  • Rebase on master to remove GitHub Actions workflow

@jackpot51
Copy link
Member Author

@crawfxrd rebased on master, updated changelog and jenkinsfile

@jackpot51 jackpot51 requested a review from crawfxrd July 2, 2025 17:54
@crawfxrd crawfxrd merged commit 7c6225e into master Jul 2, 2025
@crawfxrd crawfxrd deleted the gaze20 branch July 2, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawfxrd crawfxrd crawfxrd approved these changes

@leviport leviport leviport approved these changes

Assignees

@jackpot51 jackpot51

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackpot51 @crawfxrd @leviport