Skip to content

Conversation

kuchtact
Copy link

@kuchtact kuchtact commented Aug 19, 2025

This is a minor change to the documentation here: https://github.com/system76/firmware-open/blob/master/docs/building.md.

The firmware-open/ec/scripts/deps.sh file tries to run make git-config where git-config is defined in firmware-open/ec/. According to the current documentation, running ./ec/scripts/deps.sh should work (running from firmware-open/) but instead leads to a make: *** No rule to make target 'git-config'. Stop. error. By adding a cd then the deps.sh file can find the Makefile.

@crawfxrd
Copy link
Member

That is not needed since the submodule was updated in #606. The pushd/popd was removed in #613.

@crawfxrd crawfxrd closed this Aug 19, 2025
@kuchtact
Copy link
Author

Ah, sorry about that. Thanks!

@kuchtact kuchtact deleted the patch-1 branch August 19, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants