Add devicetree-auto support for UKI #3832
Conversation
craftyguy
force-pushed
the
devicetree-auto
branch
from
789b8f1 to
82efab3
Compare
This makes sense, but why not just make these packages install stuff to some canonical location where mkosi can look this stuff up inside the image after package installation? I'm not convinced we need a separate setting for adding an extra lookup directory for this stuff. |
Sounds good but I'm not sure how we'd want that implemented here though. kernel-install specifies So, maybe if |
|
Or what if we make that setting take a glob and if it's a glob, we include all those device trees? |
|
Ya I think either works, though if it's a glob maybe people would try to use globbing to select more specific things and would be more difficult to implement (so implementing "all" would be easier?)
Which do you prefer?
…On August 21, 2025 7:35:59 AM PDT, Daan De Meyer ***@***.***> wrote:
DaanDeMeyer left a comment (systemd/mkosi#3832)
`Devicetree=all` sounds like it could do the trick.
Or what if we make that setting take a glob and if it's a glob, we include all those device trees?
|
|
@craftyguy I think we can go with a glob for the existing And we should probably fail hard if it is a glob and type 1 entries are configured to be used since we need to be using UKIs for the devicetree-auto stuff I think. |
craftyguy
force-pushed
the
devicetree-auto
branch
from
82efab3 to
1eeec6f
Compare
|
@DaanDeMeyer ok I think I got this implemented, and tested with some globs locally (expected dtbs were embedded in dtbauto sections) |
|
Please pull in #3881 or rebase on top of it when merged. |
|
Picked to this branch |
craftyguy
force-pushed
the
devicetree-auto
branch
from
870d035 to
744d355
Compare
|
@DaanDeMeyer I tried to make this behave like the kernel modules regex/glob stuff, and in the latest patch I replaced Anyways, it seems to work when I set |
craftyguy
force-pushed
the
devicetree-auto
branch
3 times, most recently
from
70d9021 to
2058ecf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
craftyguy
force-pushed
the
devicetree-auto
branch
2 times, most recently
from
e349590 to
79c81e8
Compare
craftyguy
force-pushed
the
devicetree-auto
branch
3 times, most recently
from
156eba9 to
176e458
Compare
This renames Devicetree --> Devicetrees, and adds support for listing regex, globs, files as currently supported for KernelModule* options. When multiple devicetrees are found, they are added to dtbauto sections when building a UKI. Multiple dtbs are not supported for type 1 booting. Fixes systemd#3827
craftyguy
force-pushed
the
devicetree-auto
branch
from
176e458 to
e40fc86
Compare
This renames Devicetree --> Devicetrees, and adds support for listing
regex, globs, files as currently supported for KernelModule* options.
When multiple devicetrees are found, they are added to dtbauto sections
when building a UKI.
Multiple dtbs are not supported for type 1 booting.
Fixes #3827