-
Notifications
You must be signed in to change notification settings - Fork 265
Update compare
project to latest versions
#872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent-private-items`
Because maybe_xml 0.11 performance about x2 worse that maybe_xml 0.10, and because maybe_xml 0.10 is a leader, keep both versions
…pendently using `cargo bench --bench <group>`
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
- Coverage 60.74% 58.53% -2.22%
==========================================
Files 41 42 +1
Lines 16044 17066 +1022
==========================================
+ Hits 9746 9989 +243
- Misses 6298 7077 +779
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why did |
I don't know, but when I studied the source code of The slowdown is most likely due to the fact that in version 0.11 the parser now checks the validity of characters during parsing in each state, and not just looks for boundaries of events (like it did in 0.10 and as @bluk, just that you know |
Allow to benchmarking latest available versions. Because performance of maybe_xml degraded by 2 times, I kept version 0.10 which was (and still is) the fastest XML parser.