Skip to content

Conversation

jamwil
Copy link

@jamwil jamwil commented Aug 31, 2025

Potential solution (or intermediate solution) to #896.

@jamwil jamwil marked this pull request as ready for review August 31, 2025 14:22
@Mingun
Copy link
Collaborator

Mingun commented Aug 31, 2025

No, I think, this is bad decision. We already have poor designed make utility, where spaces handled differently than tabs and that counterintuitive. I think, the originally suggested implementation, which may be enabled by setting, would be better.

@jamwil
Copy link
Author

jamwil commented Aug 31, 2025

I'm fine with the original suggestion as it certainly will satisfy my requirements, I only propose this route as it accomplishes the same thing but is not destructive in the way you indicated. I do appreciate that broken but predictable is a better position to be in than using opinionated heuristics like this.

@jamwil jamwil changed the title de: Preserve whitespace for text events without a line break de: Preserve whitespace for all nodes containg a text event Aug 31, 2025
@jamwil
Copy link
Author

jamwil commented Aug 31, 2025

Updated as requested.

@jamwil
Copy link
Author

jamwil commented Sep 11, 2025

@Mingun I think I did this the way you described. Is there anything missing?

@Mingun
Copy link
Collaborator

Mingun commented Sep 11, 2025

Yes, the changes are mostly perfect, but I want to have configuration setting to enable them. I also want to make some small changes, which are easier to do myself than describe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants