Implement serializing CDATA #904
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 55.52% 58.70% +3.17%
==========================================
Files 42 42
Lines 15511 15242 -269
==========================================
+ Hits 8613 8948 +335
+ Misses 6898 6294 -604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Mingun <Alexander_Sergey@mail.ru>
src/se/simple_type.rs
Outdated
| serialize_cdata_as!(seq_basic: vec!["foo", "bar", "baz"] => "<![CDATA[foo]]> <![CDATA[bar]]> <![CDATA[baz]]>"); | ||
| serialize_cdata_as!(seq_with_markup_chars: vec!["<tag>", "&entity", "\"quoted\"", "with space"] => "<![CDATA[<tag>]]> <![CDATA[&entity]]> <![CDATA[\"quoted\"]]> <![CDATA[with space]]>"); | ||
| serialize_cdata_as!(seq_with_cdata_end_split: vec!["foo]]>bar", "test"] => "<![CDATA[foo]]]]><![CDATA[>bar]]> <![CDATA[test]]>"); | ||
| serialize_cdata_as!(tuple_cdata: ("first", 42, "third") => "<![CDATA[first]]> <![CDATA[42]]> <![CDATA[third]]>"); |
There was a problem hiding this comment.
It would be better, if this serialized as one CDATA section. Probably, that is possible?
There was a problem hiding this comment.
yeah agreed, need to figure out exactly how to do that nicely with serde
There was a problem hiding this comment.
alright changed it so it gets serialized to one CDATA section
one thing i'm not clear on is if there are spaces inside the items, should the spaces get escaped even when it's wrapped with a CDATA
Closes: #353