Skip to content

Mvvm closures #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Mvvm closures #3

merged 1 commit into from
Feb 18, 2019

Conversation

amadeu01
Copy link
Contributor

@amadeu01 amadeu01 commented Feb 2, 2019

Added MVVM with closures

@amadeu01
Copy link
Contributor Author

amadeu01 commented Feb 4, 2019

@tailec I'm gonna change this PR.

I'm gonna remove the first commit. Moreover, I saw something that I did wrong with the closures.

@tailec
Copy link
Owner

tailec commented Feb 8, 2019

@amadeu01 💯
What about removing ReposViewModelOutput and add closures as variables in view model? Like, here #4
Also you could leave the comment or smth that outputs can be defines as protocol etc etc.

Let's make it super simple so people that are new to iOS dev don't get overwhelmed

@amadeu01
Copy link
Contributor Author

@tailec sorry the delay, I'm gonna fix it. Then, update the PR

@amadeu01
Copy link
Contributor Author

@tailec check it now. Look if it is fine for you!

@tailec
Copy link
Owner

tailec commented Feb 17, 2019

Great!

@tailec tailec merged commit d63fa75 into tailec:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants