Remove OrackeJDK from TravisCI builds (#76)

* Remove OrackeJDK from TravisCI builds
* Use docker for database test

Author: takezoe

.travis.yml

@@ -1,8 +1,6 @@
 language: scala
 sudo: true
 jdk:
-  - oraclejdk8
-  - oraclejdk11
   - openjdk8
   - openjdk11
 script:

build.sbt

@@ -4,9 +4,10 @@ version := "1.8.1"
 scalaVersion := "2.12.8"
 gitbucketVersion := "4.31.0"
 libraryDependencies ++= Seq(
-  "org.fusesource.jansi"    %  "jansi"               % "1.16",
-  "org.scalatest"           %% "scalatest"           % "3.0.5" % "test",
-  "com.wix"                 %  "wix-embedded-mysql"  % "3.0.0" % "test",
-  "ru.yandex.qatools.embed" %  "postgresql-embedded" % "2.6" % "test"
+  "org.fusesource.jansi" %  "jansi"                % "1.16",
+  "org.scalatest"        %% "scalatest"            % "3.0.5" % "test",
+  "com.dimafeng"         %% "testcontainers-scala" % "0.27.0" % "test",
+  "org.testcontainers"   %  "mysql"                % "1.11.3" % "test",
+  "org.testcontainers"   %  "postgresql"           % "1.11.3" % "test"
 )
 

src/test/scala/io/github/gitbucket/ci/MigrationSpec.scala

@@ -2,24 +2,18 @@ package io.github.gitbucket.ci
 
 import java.sql.DriverManager
 
+import com.dimafeng.testcontainers.{MySQLContainer, PostgreSQLContainer}
 import io.github.gitbucket.solidbase.Solidbase
 import io.github.gitbucket.solidbase.model.Module
 import liquibase.database.core.{H2Database, MySQLDatabase, PostgresDatabase}
+import org.junit.runner.Description
 import org.scalatest.{FunSuite, Tag}
-
 import scala.collection.JavaConverters._
-import com.wix.mysql.EmbeddedMysql._
-import com.wix.mysql.config.Charset
-import com.wix.mysql.config.MysqldConfig._
-import com.wix.mysql.distribution.Version._
-import ru.yandex.qatools.embed.postgresql.PostgresStarter
-import ru.yandex.qatools.embed.postgresql.config.AbstractPostgresConfig.{Credentials, Net, Storage, Timeout}
-import ru.yandex.qatools.embed.postgresql.config.PostgresConfig
-import ru.yandex.qatools.embed.postgresql.distribution.Version.Main.PRODUCTION
 
 object ExternalDBTest extends Tag("ExternalDBTest")
 
 class MigrationSpec extends FunSuite {
+
   val plugin = Class.forName("Plugin").newInstance().asInstanceOf[gitbucket.core.plugin.Plugin]
 
   test("Migration H2") {
@@ -31,53 +25,47 @@ class MigrationSpec extends FunSuite {
     )
   }
 
-  test("Migration MySQL", ExternalDBTest) {
-    val config = aMysqldConfig(v5_7_latest)
-      .withPort(3306)
-      .withUser("sa", "sa")
-      .withCharset(Charset.UTF8)
-      .withServerVariable("log_syslog", 0)
-      .withServerVariable("bind-address", "127.0.0.1")
-      .build()
-
-    val mysqld = anEmbeddedMysql(config)
-      .addSchema("gitbucket")
-      .start()
+  implicit private val suiteDescription = Description.createSuiteDescription(getClass)
 
-    try {
-      new Solidbase().migrate(
-        DriverManager.getConnection("jdbc:mysql://localhost:3306/gitbucket?useSSL=false", "sa", "sa"),
-        Thread.currentThread().getContextClassLoader(),
-        new MySQLDatabase(),
-        new Module(plugin.pluginId, plugin.versions.asJava)
-      )
-    } finally {
-      mysqld.stop()
+  Seq("8.0", "5.7").foreach { tag =>
+    test(s"Migration MySQL $tag", ExternalDBTest) {
+      val container = new MySQLContainer() {
+        override val container = new org.testcontainers.containers.MySQLContainer(s"mysql:$tag") {
+          override def getDriverClassName = "org.mariadb.jdbc.Driver"
+        }
+        // TODO https://github.com/testcontainers/testcontainers-java/issues/736
+        container.withCommand("mysqld --default-authentication-plugin=mysql_native_password")
+      }
+      container.starting()
+      try {
+        new Solidbase().migrate(
+          DriverManager.getConnection(s"${container.jdbcUrl}?useSSL=false", container.username, container.password),
+          Thread.currentThread().getContextClassLoader(),
+          new MySQLDatabase(),
+          new Module(plugin.pluginId, plugin.versions.asJava)
+        )
+      } finally {
+        container.finished()
+      }
     }
   }
 
-  test("Migration PostgreSQL", ExternalDBTest) {
-    val runtime = PostgresStarter.getDefaultInstance()
-    val config = new PostgresConfig(
-      PRODUCTION,
-      new Net("localhost", 5432),
-      new Storage("gitbucket"),
-      new Timeout(),
-      new Credentials("sa", "sa")
-    )
-
-    val exec = runtime.prepare(config)
-    val process = exec.start()
+  Seq("11", "10").foreach { tag =>
+    test(s"Migration PostgreSQL $tag", ExternalDBTest) {
+      val container = PostgreSQLContainer(s"postgres:$tag")
 
-    try {
-      new Solidbase().migrate(
-        DriverManager.getConnection("jdbc:postgresql://localhost:5432/gitbucket", "sa", "sa"),
-        Thread.currentThread().getContextClassLoader(),
-        new PostgresDatabase(),
-        new Module(plugin.pluginId, plugin.versions.asJava)
-      )
-    } finally {
-      process.stop()
+      container.starting()
+      try {
+        new Solidbase().migrate(
+          DriverManager.getConnection(container.jdbcUrl, container.username, container.password),
+          Thread.currentThread().getContextClassLoader(),
+          new PostgresDatabase(),
+          new Module(plugin.pluginId, plugin.versions.asJava)
+        )
+      } finally {
+        container.finished()
+      }
     }
   }
+
 }