fix: crash of time whitelist

[yihaoDeng]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @yihaoDeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several critical issues within the data time whitelist management system, primarily focusing on preventing crashes and improving the reliability of whitelist operations. The changes enhance memory safety, prevent buffer overflows during string conversions, and correct the logic for adding, destroying, and filtering whitelist entries, ensuring the system behaves as expected under various conditions.

Highlights

• Memory Management Improvements: Significant refactoring in uvDataTimeWhiteListDestroy and uvDataTimeWhiteListAdd to correctly handle memory allocation and deallocation, preventing potential memory leaks or double-frees, especially when adding or replacing whitelist entries.
• Buffer Overflow Prevention: Enhanced uvDataTimeWhiteListToStr with robust buffer size estimation and safe string formatting using snprintf to prevent potential buffer overflows.
• Correct Whitelist Filtering Logic: Refined uvDataTimeWhiteListFilte to properly handle cases where no whitelist rule exists for a user, and to correctly apply version-based filtering.
• Explicit Function Declaration: Updated uvDataTimeWhiteListCreate to explicitly declare void parameters, improving C standard compliance.
• Accurate Version Usage: Ensured uvDataTimeWhiteListCheckConn uses the correct dataTimeWhiteListVer when calling the filtering function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces several important fixes and improvements related to data time white list management and memory handling. Key changes include correcting memory leaks and invalid memory access patterns in hash table operations, and implementing previously stubbed functionality for IP address validation. There are also minor stylistic adjustments and a logical correction in version comparison for the data time whitelist filter.

[Copilot]

Pull request overview

This PR fixes crashes in the date-time whitelist functionality by correcting memory management and pointer handling issues. The changes address fundamental flaws in how the whitelist data structures were being stored, accessed, and destroyed.

Changes:

• Fixed memory management in whitelist destruction to properly handle double-pointer storage in hash table
• Corrected pointer dereferencing throughout to match hash table's pointer-to-pointer storage pattern
• Fixed incorrect version parameter being passed in whitelist connection checks
• Implemented previously stubbed-out default address checking function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@yihaoDeng I've opened a new pull request, #34365, to work on those changes. Once the pull request is ready, I'll request review from you.