feat(taosdump): taosdump supports dumping in/out virtual table

[YamingPei]

Description

taosdump supports dumping in/out virtual table

Issue(s)

• Close https://project.feishu.cn/taosdata_td/feature/detail/6690010183

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @YamingPei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the 'taosdump' utility to fully support the backup and restoration of virtual tables. The changes involve fundamental modifications to how table metadata is stored and processed, including the introduction of a dedicated flag to identify virtual tables, a two-phase import process to handle dependencies between physical and virtual tables, and updates to SQL generation and parsing to correctly manage virtual table definitions. This ensures that 'taosdump' can reliably handle databases containing virtual tables.

Highlights

• Virtual Table Identification: Introduced a 'isVirtual' flag in the 'TableDes' structure and modified 'queryCreateTableSql' to detect virtual tables based on their 'CREATE' statement (e.g., "CREATE VTABLE" or "VIRTUAL 1" suffix).
• Two-Pass Dump-In Process: Implemented a two-pass mechanism for importing data, first processing physical tables and then virtual tables, controlled by a new global flag 'g_isVirtualPass'.
• Enhanced SQL Handling: Added support for 'CREATE VTABLE' statements during SQL parsing and generation, ensuring virtual table definitions are correctly handled during dump and restore.
• Metadata Storage for Virtual Tables: Modified the Avro schema to include a 'sql' field, allowing the 'CREATE VTABLE' statement to be stored and retrieved for virtual tables.
• Optimized Table Counting: Updated 'getTbCountOfStbNative' to use 'information_schema.ins_tables' for more efficient and accurate counting of child tables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for dumping and loading virtual tables in taosdump. The implementation introduces a two-pass approach to handle physical and virtual entities separately, which is a solid design. Several queries have been updated to use information_schema, improving robustness and efficiency. While the changes are largely correct, I've identified a critical bug related to const-correctness that could lead to undefined behavior, and a minor issue regarding the fragility of virtual table detection logic. Addressing these points will improve the quality and maintainability of the code.

[Copilot]

Pull request overview

This pull request adds support for dumping in/out virtual tables in taosdump, addressing an internal feature request. Virtual tables are a new table type that needs special handling during database export and import operations.

Changes:

• Added isVirtual boolean field to TableDes structure to track virtual table status
• Implemented two-pass dump-in process: physical tables first, then virtual tables
• Added virtual table detection logic through SQL suffix ("VIRTUAL 1") and prefix ("CREATE VTABLE") checks
• Modified Avro schema to include optional SQL field for storing virtual table creation statements
• Updated queries to use information_schema.ins_tables for better table metadata retrieval

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File	Description
tools/taos-tools/inc/dump.h	Adds isVirtual boolean field to TableDes structure to identify virtual tables
tools/taos-tools/src/taosdump.c	Implements virtual table detection, two-pass dump-in process, Avro schema changes, query updates, and CREATE VTABLE support

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.