demon: leakage in fixed-tag-value-insert-stmt#34394
demon: leakage in fixed-tag-value-insert-stmt#34394freemine wants to merge 1 commit intotaosdata:mainfrom
Conversation
freemine
requested review from
dapan1121,
guanshengliang and
hzcheng
as code owners
Summary of ChangesHello @freemine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on improving the stability and correctness of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses several memory and resource leaks within the test suite by ensuring proper deallocation of resources. The changes are correct and improve the stability of the tests. I have a few minor suggestions to enhance code consistency and cleanliness.
| ASSERT_STREQ(pFields[0].name, "tbname"); | ||
| ASSERT_STREQ(pFields[1].name, "ts"); | ||
|
|
||
| taos_stmt2_free_fields(stmt, pFields); |
There was a problem hiding this comment.
For consistency with other parts of the code where pFields is freed (e.g., lines 1220, 1255), it's good practice to set pFields to NULL after freeing it to prevent potential use-after-free issues.
taos_stmt2_free_fields(stmt, pFields);
pFields = NULL;| int tag_i = 0; | ||
| int tag_l = sizeof(int); | ||
| int tag_bl = 3; |
There was a problem hiding this comment.
The variables tag_i, tag_l, and tag_bl are declared but not used in this test case. They should be removed to improve code clarity.
| int t64_len[5] = {sizeof(int64_t), sizeof(int64_t), sizeof(int64_t), sizeof(int64_t), sizeof(int64_t)}; | ||
| int coli[5] = {1, 4, 4, 3, 2}; | ||
| int ilen[5] = {sizeof(int), sizeof(int), sizeof(int), sizeof(int), sizeof(int)}; | ||
| char is_null[2] = {1, 1}; |
There was a problem hiding this comment.
The variable is_null is declared but not used in this test case. It should be removed to improve code clarity.
1 participant
to demon:
./debug/build/bin/stmt2Test --gtest_filter=stmt2Case.stmt2_insert_fixed_tag_value