Fix set_as_windows_menu_for_nsapp() and set_as_help_menu_for_nsapp()
#322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were both using an NSMenu object that wasn't added to any menu, so macOS was ignoring them. This commit makes it so that the NSMenu instance that's added to the main app menu is used when available, or else the first NSMenu that has any supermenu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were both using an
NSMenuobject that wasn't added to any menu, so macOS was ignoring them. This PR makes it so that theNSMenuinstance that's added to the main app menu is used when available, or else the firstNSMenuthat has any supermenu.Closes #263
Closes tauri-apps/tauri#13605
Closes tauri-apps/tauri#14199