Reset DWMWA_USE_IMMERSIVE_DARK_MODE to false in clear_mica()#200
Open
XueshiQiao wants to merge 4 commits intotauri-apps:devfrom
Open
Reset DWMWA_USE_IMMERSIVE_DARK_MODE to false in clear_mica()#200XueshiQiao wants to merge 4 commits intotauri-apps:devfrom
XueshiQiao wants to merge 4 commits intotauri-apps:devfrom
Conversation
amrbashir
approved these changes
Feb 20, 2026
Member
amrbashir
left a comment
There was a problem hiding this comment.
LGTM, can you add a change file .changes directory?
rhysd
suggested changes
Mar 6, 2026
Reset the DWMWA_USE_IMMERSIVE_DARK_MODE flag to false in the clear_mica function.
Author
I've add one, could you please check it? |
…reset_in_clear_mica_function.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/ne-dwmapi-dwmwindowattribute
"For compatibility reasons, all windows default to light mode regardless of the system setting"
So i think we should reset to default mode in clear_mica()
And it performs well when switching theme(dark->light, or light->dark) in tauri applications, it performs weird without the reset operation.