Add simple default filter options function#203
Open
joeyparis wants to merge 1 commit intotbleckert:mainfrom
Open
Add simple default filter options function#203joeyparis wants to merge 1 commit intotbleckert:mainfrom
joeyparis wants to merge 1 commit intotbleckert:mainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbleckert/react-select-search/E624VfFZQWGrJQDNXqZP44oDLzkt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you set the
searchprop to true but do not provide afilterOptionsfunction then the entire options list is always returned. I added a simple default filter function that checks if thesearchvalue is included (case insensitive) anywhere in thenamevalue of each option.Alternatively, we could log an error/warning if
searchis true butfilterOptionsis null.