This repository was archived by the owner on Aug 13, 2025. It is now read-only.
Fixes issue when newly added rows are missing from file #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sheet were renamed and then new rows were added, the new rows would not be saved in the .xlsx-file. To fix that, makeCellKeyRowPrefix() and makeCellKey() were updated to use cellStoreName, so they use the same key-prefix as makeRowKey does.
tealeg
approved these changes
Apr 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sheet were renamed and then new rows were added, the new rows would not be saved in the .xlsx-file.
To fix that, makeCellKeyRowPrefix() and makeCellKey() were updated to use cellStoreName, so they use the same key-prefix as makeRowKey does.
Should fix #845