Skip to content

πŸ”€ :: (#750) νˆ¬ν‘œ 및 μ‹ μ²­ κ΅¬ν˜„ #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 147 commits into
base: develop
Choose a base branch
from

Conversation

uson1004
Copy link
Member

@uson1004 uson1004 commented May 22, 2025

κ°œμš”

νˆ¬ν‘œ 및 μ‹ μ²­ κΈ°λŠ₯을 κ΅¬ν˜„ν•˜μ˜€μŠ΅λ‹ˆλ‹€

μž‘μ—…μ‚¬ν•­

  • voting νŒ¨ν‚€μ§€λ₯Ό μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€
  • μžμŠ΅μ‹€ μ‹ μ²­ κΈ°λŠ₯을 UIμ—μ„œ 보이지 μ•Šκ²Œ ν•˜μ˜€μŠ΅λ‹ˆλ‹€
  • μ°¬λ°˜νˆ¬ν‘œ, ν•™μƒνˆ¬ν‘œ, λͺ¨λ²”학생 νˆ¬ν‘œ, 선택 νˆ¬ν‘œ νŽ˜μ΄μ§€λ₯Ό νΌλΈ”λ¦¬μ‹±ν•˜μ˜€μŠ΅λ‹ˆλ‹€
  • drawable에 이미지λ₯Ό μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€

μΆ”κ°€ 둜 ν•  말

uson1004 added 30 commits March 11, 2025 22:14
@uson1004 uson1004 self-assigned this May 22, 2025
@uson1004 uson1004 added the feat μƒˆλ‘œμš΄ κΈ°λŠ₯을 μΆ”κ°€ ν•  경우 label May 22, 2025
@uson1004 uson1004 linked an issue May 22, 2025 that may be closed by this pull request
)
navigator.navigateUp()
},
enabled = votingDetailViewModel.buttonEnabled.value && uiState.voteTopicId != null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttonEabled μƒνƒœ 변경은 viewmodelμ—μ„œ μ²˜λ¦¬ν•˜λŠ”κ²Œ 쒋을 κ±° κ°™μ•„μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€

@Leesin0222
Copy link
Member

Leesin0222 commented Jun 6, 2025

참고둜, PR을 κ³΅μœ ν•  λ•Œ 이미지λ₯Ό μ—¬λŸ¬ μž₯ μ²¨λΆ€ν•˜λŠ” 경우
μ•„λž˜μ²˜λŸΌ HTML νƒœκ·Έλ‘œ μ •λ¦¬ν•˜λ©΄ 리뷰어 μž…μž₯μ—μ„œ 더 보기 νŽΈν•œ 것 κ°™μ•„μ„œ κ³΅μœ λ“œλ¦½λ‹ˆλ‹€ πŸ™

<ul align ="center">
    <img src="이미지url" width="240" >
    <img src="이미지url" width="240" >
</ul>

μ΄λ ‡κ²Œ μ •λ ¬ν•˜λ©΄ μž‘μ—… λ‚΄μš©μ΄ ν•œλˆˆμ— λ³΄μ—¬μ„œ μ½”λ“œ 리뷰할 λ•Œ 리뷰어와 μž‘μ—…μž λͺ¨λ‘ 읽기 더 μˆ˜μ›”ν•  수 μžˆμ„ 것 κ°™μŠ΅λ‹ˆλ‹€.

μ•„λž˜λŠ” ν•΄λ‹Ή νƒœκ·Έλ₯Ό ν™œμš©ν•œ μ˜ˆμ‹œμž…λ‹ˆλ‹€ :)

ν•΄λ‹Ή νƒœκ·Έλ₯Ό μ‚¬μš©ν•œ μ˜ˆμ‹œ 사진

@JunJaBoy
Copy link
Contributor

JunJaBoy commented Jun 8, 2025

PR 컨텐츠에 피쳐 사진 μΊ‘μ³ν•΄μ„œ μ˜¬λ¦¬μ‹  것 μ•„μ£Ό μ’‹μŠ΅λ‹ˆλ‹€. ν’ˆμ§ˆ 높은 사진이 ν•„μš”ν•˜μ‹œλ©΄ Android studio emulator built-in 캑쳐 μ‚¬μš©ν•˜μ‹œλ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

@uson1004 uson1004 requested a review from parkuiery June 12, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat μƒˆλ‘œμš΄ κΈ°λŠ₯을 μΆ”κ°€ ν•  경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

νˆ¬ν‘œ 및 μ‹ μ²­ κ΅¬ν˜„
4 participants