Disabling CSRF is a security risk - and not needed #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaxil Are these changes compatible with Airflow 1.8 and 1.9 as well? |
|
Yes, the except ImportError block should take care of it |
|
@prakshalj0512 Ping. Please can you either fix this security issue and release a new version, or mark this repo as abandoned and place a prominent notice at the top of the readme? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RBAC UI for Airflow uses a different instance of the CSRF protection, so we need to import both decorators to be CSRF exempt when under RBAC UI.
Closes #73 and likely fixes #72 too