Skip to content

fix(controller): revert release.check_image_access for now #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2019

Conversation

Cryptophobia
Copy link
Member

Reverting #88 and #90 .

Because of problems with user who have 400+ apps such as these #101

Copy link
Member

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've received reports from at least two users that we broke something with this change after v2.20.0

Copy link
Member

@duanhongyi duanhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia
Copy link
Member Author

Thank you guys! Merging this now.

@Cryptophobia Cryptophobia merged commit cb94147 into teamhephy:master Jun 18, 2019
kingdonb pushed a commit to kingdonb/controller that referenced this pull request Aug 6, 2019
fix(controller): revert release.check_image_access for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants