Merge pull request #1771 from BrandonNoad/feat/rm-config-cloning

feat: remove config object cloning to fix TokenCredential issues

Author: dhensby

lib/base/connection-pool.js

@@ -7,7 +7,6 @@ const tarn = require('tarn')
 const { IDS } = require('../utils')
 const ConnectionError = require('../error/connection-error')
 const shared = require('../shared')
-const clone = require('rfdc/default')
 const { MSSQLError } = require('../error')
 
 /**
@@ -53,7 +52,7 @@ class ConnectionPool extends EventEmitter {
         throw ex
       }
     } else {
-      this.config = clone(config)
+      this.config = config
     }
 
     // set defaults

package-lock.json

@@ -37,7 +37,6 @@
     "@tediousjs/connection-string": "^0.6.0",
     "commander": "^11.0.0",
     "debug": "^4.3.3",
-    "rfdc": "^1.3.0",
     "tarn": "^3.0.2",
     "tedious": "^19.0.0"
   },

package.json

@@ -343,17 +343,6 @@ describe('Geography Parsing', () => {
   })
 })
 
-describe('config cloning', () => {
-  it('deeply clones configs', () => {
-    const options = {}
-    const pool = new BasePool({
-      server: 'Instance\\Name',
-      options
-    })
-    assert.notDeepStrictEqual(options, pool.config.options)
-  })
-})
-
 describe('value handlers', () => {
   afterEach('reset valueHandler', () => {
     sql.valueHandler.clear()