refactor: move the loginError property from Connection into Login7Handler#1662
Open
arthurschreiber wants to merge 1 commit intomasterfrom
Open
refactor: move the loginError property from Connection into Login7Handler#1662arthurschreiber wants to merge 1 commit intomasterfrom
loginError property from Connection into Login7Handler#1662arthurschreiber wants to merge 1 commit intomasterfrom
Conversation
…in7Handler` instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 85.47% 85.26% -0.21%
==========================================
Files 90 90
Lines 4859 4858 -1
Branches 924 924
==========================================
- Hits 4153 4142 -11
- Misses 702 712 +10
Partials 4 4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One less thing to keep track of in the
Connectionclass itself.