Fixed issue with extra spaces being added to LLM responses during combine. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- combining responses with `"".join` instead of `" ".join` which fixes the markdown formatting and random word splits - added extra sentence-transformer for fun
|
As far as I can tell, it still generate random spaces. It does this consequently for all my generated characters. Let me know if you need any info from me to figure out the culprit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
I noticed that when generating players the markdown was not rendering properly and there were random word splits. I have corrected this by changing how llm responses are combined.
Changes
"".joininstead of" ".join