Fix map lookup and introduce some logging

Author: chdxD1

pkg/neighborsync/neighborsync.go

@@ -226,7 +226,7 @@ func (n *NeighborSync) processUpdate(update *netlink.NeighUpdate) {
 		return
 	}
 
-	if _, ok := n.neighRefreshInterfaces.Load(update.Neigh.LinkIndex); ok {
+	if _, ok := n.neighRefreshInterfaces.Load(update.Neigh.LinkIndex); !ok {
 		return
 	}
 
@@ -359,7 +359,7 @@ func (n *NeighborSync) runBpfNeighborSync() {
 		copy(ev.IP[:], b[11:27])
 
 		skipping := false
-		if _, ok := n.receiveNeighbors.Load(int(ev.Ifindex)); ok {
+		if _, ok := n.receiveNeighbors.Load(int(ev.Ifindex)); !ok {
 			skipping = true
 		}
 

pkg/reconciler/layer2.go

@@ -227,9 +227,11 @@ func (r *reconcile) applyConfiguration(desired, current *nl.Layer2Information, a
 		*anycastTrackerInterfaces = append(*anycastTrackerInterfaces, bridgeID)
 	}
 
+	r.logger.Info("Applying Layer2 configuration", "vlan", desired.VlanID, "vni", desired.VNI, "macvlanBridgeId", current.MacVLANBridgeID(), "bridgeId", current.BridgeID(), "neighSuppression", desired.IsNeighSuppressionEnabled())
 	if current.MacVLANBridgeID() != -1 {
 		if desired.IsNeighSuppressionEnabled() {
 			if err := r.neighborSync.EnsureNeighborSuppression(current.BridgeID(), current.MacVLANBridgeID()); err != nil {
+				r.logger.Error(err, "error ensuring neighbor suppression for macvlan bridge", "vlanId", desired.VlanID, "macvlanBridgeId", current.MacVLANBridgeID())
 				return fmt.Errorf("error ensuring neighbor suppression for vlanId %d: %w", desired.VlanID, err)
 			}
 		} else {