Skip to content

Refactor/state management #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 13, 2017
Merged

Refactor/state management #109

merged 11 commits into from
Jun 13, 2017

Conversation

nfour
Copy link
Collaborator

@nfour nfour commented Jun 13, 2017

Resolves #95

  • Removed redux, move actions to ./lib
  • Upgrade react-router to v4
  • Rename handlers to containers for industry convention

We use state on the ./containers/Base Container and just pass it all down.

We can then just pass down setDefinition down to a nested input if necessary, to update the active definition, instead of dispatching in redux.

@nfour nfour changed the title WIP: Refactor/state management Refactor/state management Jun 13, 2017
@brendo brendo merged commit d9cb498 into temando:master Jun 13, 2017
brendo pushed a commit to brendo/open-api-renderer that referenced this pull request Jun 20, 2017
Remove redux, upgrade react-router to V4. Closes temando#95.
brendo pushed a commit to brendo/open-api-renderer that referenced this pull request Jun 20, 2017
Remove redux, upgrade react-router to V4. Closes temando#95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants