Skip to content

Commit e56d477

Browse files
committed
Refactor rate limit response
1 parent 60eef83 commit e56d477

File tree

4 files changed

+8
-23
lines changed

4 files changed

+8
-23
lines changed

src/RateLimit/Client.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
use GuzzleHttp\Exception\GuzzleException;
1010
use GuzzleHttp\Exception\ServerException;
1111
use TempMailIo\TempMailPhp\Constants;
12+
use TempMailIo\TempMailPhp\GenericData\SuccessResponse;
1213
use TempMailIo\TempMailPhp\Headers;
1314
use TempMailIo\TempMailPhp\RateLimit\Data\Response\GetStatusResponse;
1415
use TempMailIo\TempMailPhp\GenericData\ErrorResponse;
15-
use TempMailIo\TempMailPhp\RateLimit\Data\Response\GetStatusSuccessResponse;
1616

1717
class Client implements ClientInterface
1818
{
@@ -35,8 +35,10 @@ public function getStatus(): GetStatusResponse
3535
]);
3636

3737
if ($response->getStatusCode() === 200) {
38-
$getStatusResponse->successResponse = GetStatusSuccessResponse::create()
39-
->fromArray(json_decode($response->getBody()->getContents(), true));
38+
$getStatusResponse->successResponse = SuccessResponse::create()
39+
->fromArray([
40+
'rate_limit' => json_decode($response->getBody()->getContents(), true)
41+
]);
4042

4143
return $getStatusResponse;
4244
}

src/RateLimit/Data/Response/GetStatusResponse.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66

77
use TempMailIo\TempMailPhp\Data;
88
use TempMailIo\TempMailPhp\GenericData\ErrorResponse;
9+
use TempMailIo\TempMailPhp\GenericData\SuccessResponse;
910

1011
class GetStatusResponse extends Data
1112
{
12-
public ?GetStatusSuccessResponse $successResponse = null;
13+
public ?SuccessResponse $successResponse = null;
1314

1415
public ?ErrorResponse $errorResponse = null;
1516
}

src/RateLimit/Data/Response/GetStatusSuccessResponse.php

Lines changed: 0 additions & 18 deletions
This file was deleted.

tests/RateLimit/ClientGetStatusTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function testGetStatusSuccess(): void
4242
$this->assertInstanceOf(GetStatusResponse::class, $response);
4343
$this->assertNull($response->errorResponse);
4444
$this->assertNotNull($response->successResponse);
45-
$this->assertEquals($status, $response->successResponse->toArray());
45+
$this->assertEquals($status, $response->successResponse->rateLimit->toArray());
4646
}
4747

4848
public function testGetStatus400Error(): void

0 commit comments

Comments
 (0)